Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: workaround moment issue with DST transitions #73

Merged
merged 1 commit into from
Oct 16, 2016

Commits on Oct 15, 2016

  1. src: workaround moment issue with DST transitions

    On DST end transition, setting the date to the `startOf` `hour`,
    `minute` or `second` after having added 1 `hour`, `minute` or `second`
    to the date, would result in the date set to the initial value causing
    an infinite loop.
    
    Example:
    
    ```js
    'use strict';
    
    const moment = require('moment-timezone');
    
    var m = moment(new Date('Sun Oct 30 2016 02:00:00 GMT+0200'));
    console.log(m.toString(),
                '<-- Just 1 hour before the DST end @ Europe/Madrid');
    m.add(1, 'hours');
    console.log(m.toString(),
                '<-- DST end transition @ Europe/Madrid works correctly');
    m.startOf('hour');
    console.log(m.toString(),
                '<-- Smthing wrong?? It goes back to the previous hour');
    ```
    
    Fixes: harrisiirak#72
    Ref: moment/moment#2749
    santigimeno committed Oct 15, 2016
    Configuration menu
    Copy the full SHA
    473bb02 View commit details
    Browse the repository at this point in the history