Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change monitor scenario properties from list to map #2160

Merged
merged 3 commits into from
Jun 23, 2021

Conversation

steven-sheehy
Copy link
Member

@steven-sheehy steven-sheehy commented Jun 21, 2021

Detailed description:

  • Add a hedera.mirror.monitor.subscribe.rest.publishers property to target slow sampling to specific publishers
  • Change hedera.mirror.monitor.publish.scenarios from a list to a map
  • Change hedera.mirror.monitor.subscribe.grpc from a list to a map
  • Change hedera.mirror.monitor.subscribe.rest from a list to a map
  • Change monitor log and REST API elapsed duration to a prettier format (follow up of Add a monitor service & change threads property #2065 (comment))
  • Fix logging stacktrace on shutdown due to conflict between Spring Boot and Log4j2's logging shutdown mechanism
  • Fix monitor REST API client IP detection by relying upon standard X-Forwarded-For header, if available

Which issue(s) this PR fixes:

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
@steven-sheehy steven-sheehy added enhancement Type: New feature P3 monitor Area: Monitoring and dashboard breaking Contains a breaking change that warrants mention in the release notes labels Jun 21, 2021
@steven-sheehy steven-sheehy added this to the Mirror 0.37.0 milestone Jun 21, 2021
@steven-sheehy steven-sheehy requested a review from a team June 21, 2021 19:55
@steven-sheehy steven-sheehy self-assigned this Jun 21, 2021
@codecov
Copy link

codecov bot commented Jun 21, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@bce2fc6). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2160   +/-   ##
=======================================
  Coverage        ?   81.73%           
  Complexity      ?     2135           
=======================================
  Files           ?      412           
  Lines           ?    10987           
  Branches        ?      936           
=======================================
  Hits            ?     8980           
  Misses          ?     1695           
  Partials        ?      312           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bce2fc6...1d8b0f6. Read the comment docs.

docs/configuration.md Outdated Show resolved Hide resolved
Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
@sonarcloud
Copy link

sonarcloud bot commented Jun 22, 2021

Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven-sheehy steven-sheehy merged commit 536ccda into main Jun 23, 2021
@steven-sheehy steven-sheehy deleted the map-monitor-properties branch June 23, 2021 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Contains a breaking change that warrants mention in the release notes enhancement Type: New feature monitor Area: Monitoring and dashboard P3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants