Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Corner cases for ethereum transactions #13229

Closed
wants to merge 7 commits into from
Closed

test: Corner cases for ethereum transactions #13229

wants to merge 7 commits into from

Conversation

JivkoKelchev
Copy link
Contributor

@JivkoKelchev JivkoKelchev commented May 13, 2024 •
edited

Description:

This PR adds ethereum transactions to the Xtests.

Related issue(s):

Fixes #12627

Notes for reviewer:

Throttle definitions were added, because we need to validate childThrottleIsAvailable on commit here.

I tried to add tests regarding the optional access list of EIP-2039 transactions, but I didn't find any access list implementations. Furthermore, when I try to encode ethereum data with the access list, it fails here.
I also tried to modify encode encodeTx(), but the consumed gas was the same as before.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@JivkoKelchev
Add throttle definitions to X tests component
38483dc 
Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>
@JivkoKelchev
Add gasCalculator to X tests component
69e217a 
Add PayReceivable contract for ethereum tests
Add gasUsed assertion

Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>
@JivkoKelchev
Merge branch 'develop' into 12627-corner-cases-for-Ethereum-transactions
cb0aa61 
# Conflicts:
#	hedera-node/hedera-app/src/xtest/java/common/AbstractXTest.java
@github-actions GitHub Actions
Copy link

github-actions bot commented May 13, 2024 •
edited

Node: HAPI Test (Restart) Results

2 tests   2 ✅  8m 6s ⏱️
2 suites  0 💤
2 files    0 ❌

Results for commit bf9b420.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 13, 2024 •
edited

Node: HAPI Test (Node Death Reconnect) Results

2 tests   2 ✅  8m 47s ⏱️
2 suites  0 💤
2 files    0 ❌

Results for commit bf9b420.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 13, 2024 •
edited

Node: HAPI Test (Token) Results

237 tests   235 ✅  20m 29s ⏱️
 17 suites    2 💤
 17 files      0 ❌

Results for commit bf9b420.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 13, 2024 •
edited

Node: HAPI Test (Misc) Results

468 tests   458 ✅  42m 50s ⏱️
 77 suites   10 💤
 77 files      0 ❌

Results for commit bf9b420.

♻️ This comment has been updated with latest results.

@JivkoKelchev
revert @singleton on provideHandleContextCreator
cba370e 
Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>
@JivkoKelchev JivkoKelchev marked this pull request as ready for review May 13, 2024 11:20
@JivkoKelchev JivkoKelchev requested a review from a team as a code owner May 13, 2024 11:20
@github-actions GitHub Actions
Copy link

github-actions bot commented May 13, 2024 •
edited

Node: HAPI Test (Crypto) Results

335 tests   335 ✅  41m 49s ⏱️
 25 suites    0 💤
 25 files      0 ❌

Results for commit bf9b420.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 13, 2024 •
edited

Node: HAPI Test (Time Consuming) Results

21 tests   21 ✅  54m 36s ⏱️
 3 suites   0 💤
 3 files     0 ❌

Results for commit bf9b420.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 13, 2024 •
edited

Node: Unit Test Results

  2 318 files  + 1    2 318 suites  +1   3h 14m 50s ⏱️ + 2m 58s
119 057 tests +10  118 990 ✅ +10  67 💤 ±0  0 ❌ ±0 
127 618 runs  +10  127 551 ✅ +10  67 💤 ±0  0 ❌ ±0 

Results for commit bf9b420. ± Comparison against base commit b86dab5.

This pull request removes 4016 and adds 3789 tests. Note that renamed tests count towards both. 

  
             IssuerDN: CN=s-aaaa
            SubjectDN: CN=s-aaaa
           Final Date: Fri Jan 01 00:00:00 UTC 2100
           Public Key: RSA Public Key [2e:28:bc:1e:d3:83:25:92:8e:cb:98:b1:b6:84:06:9c:d5:d8:14:d5],[56:66:d1:a4]
           Start Date: Sat Jan 01 00:00:00 UTC 2000
         SerialNumber: 12482092706667292405
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5e3…
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5e…
…

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [4] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [6] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [7]   
  
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [10] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@a784a092
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [11] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@26f3c493
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [12] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@165875aa
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [13] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@341cb3fc
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [14] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@16a1c558
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [15] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@77b69d78
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [16] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@945629d3
…

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 13, 2024 •
edited

Node: HAPI Test (Smart Contract) Results

605 tests   605 ✅  1h 12m 49s ⏱️
 63 suites    0 💤
 63 files      0 ❌

Results for commit bf9b420.

♻️ This comment has been updated with latest results.

@mustafauzunn mustafauzunn added the Limechain Work planned for the LimeChain team label May 14, 2024
@JivkoKelchev
Merge branch 'develop' into 12627-corner-cases-for-Ethereum-transactions
42653ea 
# Conflicts:
#	hedera-node/hedera-app/src/xtest/java/common/AbstractXTest.java
@JivkoKelchev
Fix merge conflicts
f36624f 
Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>
@JivkoKelchev
Fix merge conflicts
bf9b420 
Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>
@vtronkov
Copy link
Contributor

Closing this PR because we will deprecate the x-tests: #13425

@vtronkov vtronkov closed this May 23, 2024
@vtronkov vtronkov mentioned this pull request May 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasperpotts jasperpotts Awaiting requested review from jasperpotts jasperpotts is a code owner automatically assigned from hashgraph/hedera-base

Assignees

@JivkoKelchev JivkoKelchev

Labels
Limechain Work planned for the LimeChain team
Projects
None yet
Milestone
No milestone
3 participants
@JivkoKelchev @vtronkov @mustafauzunn