Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Metrics impl module started #13264

Merged
merged 25 commits into from
May 29, 2024
Merged

chore: Metrics impl module started #13264

merged 25 commits into from
May 29, 2024

Conversation

hendrikebbers
Copy link
Member

@hendrikebbers hendrikebbers commented May 14, 2024 •
edited

Introduces the metrics impl module and moves basic implementations to that module.
Several classes are renamed to Platform*Metric. All those classes depend on platform code and must be refactored/moved in a future PR.
Fixes #13268

@hendrikebbers
metrics-impl started
f88d6b5 
Signed-off-by: Hendrik Ebbers <hendrik.ebbers@web.de>
@hendrikebbers
metrics-impl started
c38a633 
Signed-off-by: Hendrik Ebbers <hendrik.ebbers@web.de>
@hendrikebbers
compile fixes
54d01d1 
Signed-off-by: Hendrik Ebbers <hendrik.ebbers@web.de>
@hendrikebbers
Merge branch 'develop' into metrics-impl
a2d27f2
@hendrikebbers
quality gate
b543ba3 
Signed-off-by: Hendrik Ebbers <hendrik.ebbers@web.de>
@hendrikebbers
quality gate
cc38c57 
Signed-off-by: Hendrik Ebbers <hendrik.ebbers@web.de>
@github-actions GitHub Actions
Copy link

github-actions bot commented May 14, 2024 •
edited

Node: HAPI Test (Node Death Reconnect) Results

2 tests   2 ✅  5m 52s ⏱️
2 suites  0 💤
2 files    0 ❌

Results for commit 07517f2.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 14, 2024 •
edited

Node: HAPI Test (Restart) Results

2 tests   2 ✅  6m 0s ⏱️
2 suites  0 💤
2 files    0 ❌

Results for commit 07517f2.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 14, 2024 •
edited

Node: HAPI Test (Time Consuming) Results

18 tests   18 ✅  22m 16s ⏱️
 3 suites   0 💤
 3 files     0 ❌

Results for commit 07517f2.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 14, 2024 •
edited

Node: HAPI Test (Token) Results

 19 files   19 suites   5m 48s ⏱️
256 tests 256 ✅ 0 💤 0 ❌
259 runs  259 ✅ 0 💤 0 ❌

Results for commit 07517f2.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 14, 2024 •
edited

Node: HAPI Test (Crypto) Results

 22 files   22 suites   11m 55s ⏱️
349 tests 349 ✅ 0 💤 0 ❌
355 runs  355 ✅ 0 💤 0 ❌

Results for commit 07517f2.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 14, 2024 •
edited

Node: HAPI Test (Misc) Results

 50 files   50 suites   22m 23s ⏱️
356 tests 356 ✅ 0 💤 0 ❌
373 runs  373 ✅ 0 💤 0 ❌

Results for commit 07517f2.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 14, 2024 •
edited

Node: Unit Test Results

  2 322 files  ±0    2 322 suites  ±0   2h 57m 47s ⏱️ + 7m 7s
119 361 tests  - 7  119 294 ✅  - 7  67 💤 ±0  0 ❌ ±0 
127 904 runs   - 7  127 837 ✅  - 7  67 💤 ±0  0 ❌ ±0 

Results for commit 07517f2. ± Comparison against base commit ecef01f.

This pull request removes 4161 and adds 3910 tests. Note that renamed tests count towards both. 

  
             IssuerDN: CN=s-aaaa
            SubjectDN: CN=s-aaaa
           Final Date: Fri Jan 01 00:00:00 UTC 2100
           Public Key: RSA Public Key [2e:28:bc:1e:d3:83:25:92:8e:cb:98:b1:b6:84:06:9c:d5:d8:14:d5],[56:66:d1:a4]
           Start Date: Sat Jan 01 00:00:00 UTC 2000
         SerialNumber: 12482092706667292405
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5e…
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5…
…

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [4] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [6] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [7]   
  
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [10] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@d37f275f
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [11] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@4a79d99e
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [12] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@757dfa61
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [13] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@6f6f3cf4
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [14] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@8e16e9a0
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [15] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@f446af05
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [16] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@7b947e81
…
This pull request removes 1 skipped test and adds 1 skipped test. Note that renamed tests count towards both. 
com.swirlds.common.metrics.platform.DefaultSpeedometerMetricTest ‑ testDistributionForRegularRateWithUpdates()

com.swirlds.common.metrics.platform.PlatformSpeedometerMetricTest ‑ testDistributionForRegularRateWithUpdates()

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 14, 2024 •
edited

Node: HAPI Test (Smart Contract) Results

 66 files   66 suites   21m 56s ⏱️
591 tests 591 ✅ 0 💤 0 ❌
618 runs  618 ✅ 0 💤 0 ❌

Results for commit 07517f2.

♻️ This comment has been updated with latest results.

@hendrikebbers
tests fixed
7f9447a 
Signed-off-by: Hendrik Ebbers <hendrik.ebbers@web.de>
@hendrikebbers hendrikebbers self-assigned this May 14, 2024
@hendrikebbers hendrikebbers marked this pull request as ready for review May 14, 2024 14:34
@hendrikebbers hendrikebbers requested review from a team as code owners May 14, 2024 14:34
@hendrikebbers
based on review
8d14478 
Signed-off-by: Hendrik Ebbers <hendrik.ebbers@web.de>
@hendrikebbers
based on review
6ff3491 
Signed-off-by: Hendrik Ebbers <hendrik.ebbers@web.de>
@hendrikebbers
based on review
ff6a3c1 
Signed-off-by: Hendrik Ebbers <hendrik.ebbers@web.de>
@hendrikebbers
based on review
56a2a6d 
Signed-off-by: Hendrik Ebbers <hendrik.ebbers@web.de>
@hendrikebbers
Merge branch 'develop' into metrics-impl
a8cbc53
mxtartaglia-sl
mxtartaglia-sl previously approved these changes May 24, 2024
View reviewed changes
nathanklick
nathanklick previously approved these changes May 24, 2024
View reviewed changes
Copy link
Member

@nathanklick nathanklick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved w.r.t. Gradle changes only.

cody-littley
cody-littley reviewed May 24, 2024
View reviewed changes
...rm-sdk/swirlds-common/src/main/java/com/swirlds/common/metrics/platform/PlatformCounter.java Show resolved Hide resolved
...rlds-common/src/main/java/com/swirlds/common/metrics/platform/PlatformDoubleAccumulator.java Show resolved Hide resolved
...dk/swirlds-common/src/main/java/com/swirlds/common/metrics/platform/PlatformDoubleGauge.java Show resolved Hide resolved
...lds-common/src/main/java/com/swirlds/common/metrics/platform/PlatformIntegerAccumulator.java Show resolved Hide resolved
...k/swirlds-common/src/main/java/com/swirlds/common/metrics/platform/PlatformIntegerGauge.java Show resolved Hide resolved
...rlds-common/src/main/java/com/swirlds/common/metrics/platform/PlatformDoubleAccumulator.java Outdated Show resolved Hide resolved
...rm-sdk/swirlds-common/src/main/java/com/swirlds/common/metrics/platform/PlatformCounter.java Outdated Show resolved Hide resolved
...-sdk/swirlds-common/src/main/java/com/swirlds/common/metrics/platform/PlatformLongGauge.java Show resolved Hide resolved
...-sdk/swirlds-common/src/main/java/com/swirlds/common/metrics/platform/PlatformLongGauge.java Outdated Show resolved Hide resolved
...m-sdk/swirlds-metrics-impl/src/main/java/com/swirlds/metrics/impl/DefaultMetricsFactory.java Show resolved Hide resolved
@hendrikebbers @cody-littley
Update platform-sdk/swirlds-common/src/main/java/com/swirlds/common/m…
36f3b66 
…etrics/platform/PlatformCounter.java

Co-authored-by: Cody Littley <56973212+cody-littley@users.noreply.github.com>
Signed-off-by: Hendrik Ebbers <hendrik.ebbers@web.de>
hendrikebbers and others added 8 commits May 24, 2024 15:44
@hendrikebbers @cody-littley
Update platform-sdk/swirlds-common/src/main/java/com/swirlds/common/m…
49cfbc6 
…etrics/platform/PlatformDoubleAccumulator.java

Co-authored-by: Cody Littley <56973212+cody-littley@users.noreply.github.com>
Signed-off-by: Hendrik Ebbers <hendrik.ebbers@web.de>
@hendrikebbers @cody-littley
Update platform-sdk/swirlds-common/src/main/java/com/swirlds/common/m…
404e1ae 
…etrics/platform/PlatformLongGauge.java

Co-authored-by: Cody Littley <56973212+cody-littley@users.noreply.github.com>
Signed-off-by: Hendrik Ebbers <hendrik.ebbers@web.de>
@hendrikebbers @cody-littley
Update platform-sdk/swirlds-common/src/main/java/com/swirlds/common/m…
f605896 
…etrics/platform/PlatformLongAccumulator.java

Co-authored-by: Cody Littley <56973212+cody-littley@users.noreply.github.com>
Signed-off-by: Hendrik Ebbers <hendrik.ebbers@web.de>
@hendrikebbers @cody-littley
Update platform-sdk/swirlds-common/src/main/java/com/swirlds/common/m…
a4e5dff 
…etrics/platform/PlatformIntegerGauge.java

Co-authored-by: Cody Littley <56973212+cody-littley@users.noreply.github.com>
Signed-off-by: Hendrik Ebbers <hendrik.ebbers@web.de>
@hendrikebbers @cody-littley
Update platform-sdk/swirlds-common/src/main/java/com/swirlds/common/m…
41089c9 
…etrics/platform/PlatformIntegerAccumulator.java

Co-authored-by: Cody Littley <56973212+cody-littley@users.noreply.github.com>
Signed-off-by: Hendrik Ebbers <hendrik.ebbers@web.de>
@hendrikebbers @cody-littley
Update platform-sdk/swirlds-common/src/main/java/com/swirlds/common/m…
a68a38e 
…etrics/platform/PlatformDoubleGauge.java

Co-authored-by: Cody Littley <56973212+cody-littley@users.noreply.github.com>
Signed-off-by: Hendrik Ebbers <hendrik.ebbers@web.de>
@hendrikebbers
Merge branch 'develop' into metrics-impl
4ee24d6
@hendrikebbers
javadoc
07517f2 
Signed-off-by: Hendrik Ebbers <hendrik.ebbers@web.de>
netopyr
netopyr approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@netopyr netopyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in regards to Services code

@hendrikebbers hendrikebbers merged commit 518f75d into develop May 29, 2024
47 of 48 checks passed
@hendrikebbers hendrikebbers deleted the metrics-impl branch May 29, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@netopyr netopyr netopyr approved these changes

@jeromy-cannon jeromy-cannon jeromy-cannon approved these changes

@cody-littley cody-littley cody-littley approved these changes

@edward-swirldslabs edward-swirldslabs edward-swirldslabs approved these changes

@anthony-swirldslabs anthony-swirldslabs anthony-swirldslabs approved these changes

@mxtartaglia-sl mxtartaglia-sl mxtartaglia-sl approved these changes

@isavov isavov Awaiting requested review from isavov isavov is a code owner automatically assigned from hashgraph/release-engineering

@leninmehedy leninmehedy Awaiting requested review from leninmehedy leninmehedy is a code owner automatically assigned from hashgraph/release-engineering-managers

@timo0 timo0 Awaiting requested review from timo0 timo0 is a code owner automatically assigned from hashgraph/platform-base

@imalygin imalygin Awaiting requested review from imalygin imalygin is a code owner automatically assigned from hashgraph/platform-data

@OlegMazurov OlegMazurov Awaiting requested review from OlegMazurov OlegMazurov is a code owner automatically assigned from hashgraph/platform-architects

@jasperpotts jasperpotts Awaiting requested review from jasperpotts jasperpotts is a code owner automatically assigned from hashgraph/hedera-base

@nathanklick nathanklick Awaiting requested review from nathanklick

Assignees

@hendrikebbers hendrikebbers

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Externalize basic metric implementations from swirlds-common
8 participants
@hendrikebbers @netopyr @jeromy-cannon @nathanklick @cody-littley @edward-swirldslabs @anthony-swirldslabs @mxtartaglia-sl