Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix restart test flakiness #13285

Closed
wants to merge 2 commits into from
Closed

Fix restart test flakiness #13285

wants to merge 2 commits into from

Conversation

Neeharika-Sompalli
Copy link
Member

WIP

@Neeharika-Sompalli
fix restart test
95b58c3 
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
@Neeharika-Sompalli Neeharika-Sompalli self-assigned this May 14, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 14, 2024 •
edited

Node: HAPI Test (Restart) Results

2 tests   2 ✅  8m 43s ⏱️
2 suites  0 💤
2 files    0 ❌

Results for commit 704328f.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 14, 2024 •
edited

Node: HAPI Test (Node Death Reconnect) Results

2 tests   2 ✅  18m 26s ⏱️
2 suites  0 💤
2 files    0 ❌

Results for commit 704328f.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 14, 2024 •
edited

Node: HAPI Test (Token) Results

237 tests   235 ✅  24m 43s ⏱️
 17 suites    2 💤
 17 files      0 ❌

Results for commit 704328f.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

Node: HAPI Test (Crypto) Results

335 tests   335 ✅  40m 24s ⏱️
 25 suites    0 💤
 25 files      0 ❌

Results for commit 95b58c3.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 14, 2024 •
edited

Node: HAPI Test (Misc) Results

468 tests   458 ✅  47m 15s ⏱️
 77 suites   10 💤
 77 files      0 ❌

Results for commit 704328f.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 14, 2024 •
edited

Node: HAPI Test (Time Consuming) Results

21 tests   21 ✅  54m 6s ⏱️
 3 suites   0 💤
 3 files     0 ❌

Results for commit 704328f.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 14, 2024 •
edited

Node: Unit Test Results

  2 309 files  ±0    2 309 suites  ±0   3h 32m 17s ⏱️ ±0s
118 995 tests ±0  118 928 ✅ ±0  67 💤 ±0  0 ❌ ±0 
127 556 runs  ±0  127 489 ✅ ±0  67 💤 ±0  0 ❌ ±0 

Results for commit 704328f. ± Comparison against base commit 32c6bbb.

This pull request removes 356 and adds 121 tests. Note that renamed tests count towards both. 

  
             IssuerDN: CN=s-aaaa
            SubjectDN: CN=s-aaaa
           Final Date: Fri Jan 01 00:00:00 UTC 2100
           Public Key: RSA Public Key [2e:28:bc:1e:d3:83:25:92:8e:cb:98:b1:b6:84:06:9c:d5:d8:14:d5],[56:66:d1:a4]
           Start Date: Sat Jan 01 00:00:00 UTC 2000
         SerialNumber: 12482092706667292405
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5…
   Address[id=0,nickname=7Nt1ZPfO,selfName=aaaa,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=33788,hostnameExternal=136.70.147.145,portExternalIpv4=33788,sigPublicKey=<null>,agreePublicKey=<null>,sigCert=com.swirlds.platform.crypto.SerializableX509Certificate@2f188eec,agreeCert=com.swirlds.platform.crypto.SerializableX509Certificate@584606ce,memo=XoXfcwxW],
…

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [4] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [6] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [7]   
  
com.hedera.node.app.state.merkle.StateMetadataTest ‑ [11] 

com.hedera.node.app.state.merkle.StateMetadataTest ‑ [203] Some Legal Characters 

com.hedera.node.app.state.merkle.StateMetadataTest ‑ [395] 
 Some Legal Characters
com.swirlds.platform.crypto.KeysAndCertsTest ‑ [1] AddressBook {
   Address[id=0,nickname=ILWD5cg7,selfName=aaaa,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=30742,hostnameExternal=5.140.37.176,portExternalIpv4=30742,sigPublicKey=<null>,agreePublicKey=<null>,sigCert=com.swirlds.platform.crypto.SerializableX509Certificate@368f3392,agreeCert=com.swirlds.platform.crypto.SerializableX509Certificate@721b5e52,memo=vLuxhksF],
   Address[id=3,nickname=jPRsRaKi,selfName=aaab,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=7486,hostnameExternal=22…, {0=KeysAndCerts[sigKeyPair=java.security.KeyPair@2d63dd21, agrKeyPair=java.security.KeyPair@1d7da591, sigCert=[
[
  Version: V3
  Subject: CN=s-aaaa
  Signature Algorithm: SHA384withRSA, OID = 1.2.840.113549.1.1.12

  Key:  Sun RSA public key, 3072 bits
  params: null
  modulus: 399359783971008386823194517591913909076180800663617430152293322362851354916562240539217992749052543798926670565779538052222399243364172487884744393106571360720093667481704909500324706084082081682560810453972293976421988390921489916…
com.swirlds.platform.crypto.KeysAndCertsTest ‑ [2] AddressBook {
   Address[id=0,nickname=IGR26pU9,selfName=aaaa,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=52126,hostnameExternal=241.98.13.83,portExternalIpv4=52126,sigPublicKey=<null>,agreePublicKey=<null>,sigCert=com.swirlds.platform.crypto.SerializableX509Certificate@3bda8856,agreeCert=com.swirlds.platform.crypto.SerializableX509Certificate@3300893d,memo=MBeXb9GA],
   Address[id=1,nickname=O3uZHf0C,selfName=aaab,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=18373,hostnameExternal=2…, {0=KeysAndCerts[sigKeyPair=java.security.KeyPair@747a8258, agrKeyPair=java.security.KeyPair@190faba4, sigCert=  [0]         Version: 3
         SerialNumber: 12482092706667292405
             IssuerDN: CN=s-aaaa
           Start Date: Sat Jan 01 00:00:00 UTC 2000
           Final Date: Fri Jan 01 00:00:00 UTC 2100
            SubjectDN: CN=s-aaaa
           Public Key: RSA Public Key [2e:28:bc:1e:d3:83:25:92:8e:cb:98:b1:b6:84:06:9c:d5:d8:14:d5],[56:66:d1:a4]
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5…
com.swirlds.platform.network.connectivity.InboundConnectionHandlerTest ‑ [1] AddressBook {
   Address[id=0,nickname=9DapU7mL,selfName=aaaa,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=30667,hostnameExternal=183.191.49.108,portExternalIpv4=30667,sigPublicKey=<null>,agreePublicKey=<null>,sigCert=com.swirlds.platform.crypto.SerializableX509Certificate@29e95ce0,agreeCert=com.swirlds.platform.crypto.SerializableX509Certificate@18a566d,memo=zHa2OARU],
   Address[id=3,nickname=yiqBYYv3,selfName=aaab,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=11127,hostnameExternal=…, {0=KeysAndCerts[sigKeyPair=java.security.KeyPair@363ad000, agrKeyPair=java.security.KeyPair@446ac071, sigCert=[
[
  Version: V3
  Subject: CN=s-aaaa
  Signature Algorithm: SHA384withRSA, OID = 1.2.840.113549.1.1.12

  Key:  Sun RSA public key, 3072 bits
  params: null
  modulus: 399359783971008386823194517591913909076180800663617430152293322362851354916562240539217992749052543798926670565779538052222399243364172487884744393106571360720093667481704909500324706084082081682560810453972293976421988390921489916…
com.swirlds.platform.network.connectivity.InboundConnectionHandlerTest ‑ [1] AddressBook {
   Address[id=0,nickname=zaZXnvGs,selfName=aaaa,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=11995,hostnameExternal=239.86.33.248,portExternalIpv4=11995,sigPublicKey=<null>,agreePublicKey=<null>,sigCert=com.swirlds.platform.crypto.SerializableX509Certificate@30846276,agreeCert=com.swirlds.platform.crypto.SerializableX509Certificate@492e27aa,memo=ANPtAbr1],
   Address[id=1,nickname=A4qAEvSs,selfName=aaab,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=10927,hostnameExternal=…, {0=KeysAndCerts[sigKeyPair=java.security.KeyPair@1da9c7a6, agrKeyPair=java.security.KeyPair@7ae657c5, sigCert=[
[
  Version: V3
  Subject: CN=s-aaaa
  Signature Algorithm: SHA384withRSA, OID = 1.2.840.113549.1.1.12

  Key:  Sun RSA public key, 3072 bits
  params: null
  modulus: 399359783971008386823194517591913909076180800663617430152293322362851354916562240539217992749052543798926670565779538052222399243364172487884744393106571360720093667481704909500324706084082081682560810453972293976421988390921489916…
…

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 14, 2024 •
edited

Node: HAPI Test (Smart Contract) Results

604 tests   603 ✅  1h 20m 44s ⏱️
 63 suites    0 💤
 63 files      1 ❌

For more details on these failures, see this check.

Results for commit 704328f.

♻️ This comment has been updated with latest results.

@Neeharika-Sompalli Neeharika-Sompalli marked this pull request as ready for review May 16, 2024 14:06
@Neeharika-Sompalli Neeharika-Sompalli requested review from a team as code owners May 16, 2024 14:06
@codecov Codecov
Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.21%. Comparing base (32c6bbb) to head (704328f).

Additional details and impacted files 
@@            Coverage Diff             @@
##             develop   #13285   +/-   ##
==========================================
  Coverage      67.21%   67.21%           
  Complexity     36161    36161           
==========================================
  Files           3700     3700           
  Lines         148961   148961           
  Branches       15501    15501           
==========================================
  Hits          100126   100126           
  Misses         44505    44505           
  Partials        4330     4330

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Neeharika-Sompalli
Copy link
Member Author

Will be addressed in one of Michael's PR. Closing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@netopyr netopyr Awaiting requested review from netopyr netopyr is a code owner automatically assigned from hashgraph/hedera-base

@acuarica acuarica Awaiting requested review from acuarica acuarica is a code owner automatically assigned from hashgraph/hedera-smart-contracts

Assignees

@Neeharika-Sompalli Neeharika-Sompalli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Neeharika-Sompalli