Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: do not write test data into source folder #13303

Merged
merged 1 commit into from
May 23, 2024

Conversation

jjohannes
Copy link
Collaborator

This will always invalidate the "test" task after it ran and it will never be UP-TO-DATE. This is, because you change the inputs, in this case the test sources/resources, of the task while it is running.

Description:

Related issue(s):

Discovered while working on #11565

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Copy link

github-actions bot commented May 15, 2024

Node: HAPI Test (Restart) Results

2 tests   2 ✅  8m 15s ⏱️
2 suites  0 💤
2 files    0 ❌

Results for commit 9f1f29a.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 15, 2024

Node: HAPI Test (Node Death Reconnect) Results

2 tests   2 ✅  10m 26s ⏱️
2 suites  0 💤
2 files    0 ❌

Results for commit 9f1f29a.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 15, 2024

Node: HAPI Test (Token) Results

237 tests   235 ✅  22m 4s ⏱️
 17 suites    2 💤
 17 files      0 ❌

Results for commit 9f1f29a.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 15, 2024

Node: HAPI Test (Misc) Results

468 tests   458 ✅  38m 35s ⏱️
 77 suites   10 💤
 77 files      0 ❌

Results for commit 9f1f29a.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 15, 2024

Node: HAPI Test (Crypto) Results

335 tests   335 ✅  43m 24s ⏱️
 25 suites    0 💤
 25 files      0 ❌

Results for commit 9f1f29a.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 15, 2024

Node: HAPI Test (Time Consuming) Results

21 tests   21 ✅  54m 41s ⏱️
 3 suites   0 💤
 3 files     0 ❌

Results for commit 9f1f29a.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 15, 2024

Node: Unit Test Results

  2 309 files  ±0    2 309 suites  ±0   1h 45m 32s ⏱️ - 1h 35m 9s
118 994 tests ±0  118 927 ✅ ±0  67 💤 ±0  0 ❌ ±0 
127 555 runs  ±0  127 488 ✅ ±0  67 💤 ±0  0 ❌ ±0 

Results for commit 9f1f29a. ± Comparison against base commit 474f5ff.

This pull request removes 4005 and adds 3768 tests. Note that renamed tests count towards both.

  
             IssuerDN: CN=s-aaaa
            SubjectDN: CN=s-aaaa
           Final Date: Fri Jan 01 00:00:00 UTC 2100
           Public Key: RSA Public Key [2e:28:bc:1e:d3:83:25:92:8e:cb:98:b1:b6:84:06:9c:d5:d8:14:d5],[56:66:d1:a4]
           Start Date: Sat Jan 01 00:00:00 UTC 2000
         SerialNumber: 12482092706667292405
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5e…
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5…
…
com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [4] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [6] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [7]   
  
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [10] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@c59c6bac
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [11] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@51e4aa3d
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [12] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@3e077498
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [13] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@e5770f4a
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [14] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@301d4752
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [15] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@ed30e78d
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [16] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@f9d71bc6
…

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.75%. Comparing base (474f5ff) to head (9f1f29a).

Additional details and impacted files
@@              Coverage Diff              @@
##             develop   #13303      +/-   ##
=============================================
- Coverage      61.75%   61.75%   -0.01%     
  Complexity     31252    31252              
=============================================
  Files           3446     3446              
  Lines         141289   141289              
  Branches       14781    14781              
=============================================
- Hits           87249    87246       -3     
- Misses         50155    50165      +10     
+ Partials        3885     3878       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented May 15, 2024

Node: HAPI Test (Smart Contract) Results

604 tests   604 ✅  1h 11m 28s ⏱️
 63 suites    0 💤
 63 files      0 ❌

Results for commit 9f1f29a.

♻️ This comment has been updated with latest results.

@jjohannes jjohannes force-pushed the 11565-do-not-write-test-data-into-src branch from b332703 to 7feab13 Compare May 15, 2024 17:59
This will always invalidate the "test" task after it ran and it will
never be UP-TO-DATE. This is, because you change the inputs, in this
case the test sources/resources, of the task while it is running.

Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
@jjohannes jjohannes force-pushed the 11565-do-not-write-test-data-into-src branch from 7feab13 to 9f1f29a Compare May 16, 2024 05:19
@jjohannes jjohannes self-assigned this May 16, 2024
@jjohannes jjohannes merged commit c15fbda into develop May 23, 2024
47 checks passed
@jjohannes jjohannes deleted the 11565-do-not-write-test-data-into-src branch May 23, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants