-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Move from Log4j Appender to Provider pattern (for performance tests) #13305
base: develop
Are you sure you want to change the base?
Conversation
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
Node: HAPI Test (Restart) Results2 tests 2 ✅ 6m 33s ⏱️ Results for commit 0b6440b. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Node Death Reconnect) Results2 tests 0 ✅ 0s ⏱️ For more details on these failures, see this check. Results for commit 0876262. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Token) Results234 tests 0 ✅ 0s ⏱️ For more details on these failures, see this check. Results for commit 0876262. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Crypto) Results307 tests 0 ✅ 1s ⏱️ For more details on these failures, see this check. Results for commit 0876262. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Time Consuming) Results9 tests 0 ✅ 0s ⏱️ For more details on these failures, see this check. Results for commit 0876262. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Smart Contract) Results592 tests 0 ✅ 1s ⏱️ For more details on these failures, see this check. Results for commit 0876262. ♻️ This comment has been updated with latest results. |
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
Node: HAPI Test (Misc) Results468 tests 0 ✅ 2s ⏱️ For more details on these failures, see this check. Results for commit 0876262. ♻️ This comment has been updated with latest results. |
Node: Unit Test Results 2 319 files ± 0 2 319 suites ±0 3h 16m 0s ⏱️ - 33m 11s For more details on these failures, see this check. Results for commit 0b6440b. ± Comparison against base commit 5b55935. This pull request removes 4036 and adds 4109 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #13305 +/- ##
==============================================
+ Coverage 0 61.76% +61.76%
- Complexity 0 31258 +31258
==============================================
Files 0 3446 +3446
Lines 0 141251 +141251
Branches 0 14780 +14780
==============================================
+ Hits 0 87243 +87243
- Misses 0 50134 +50134
- Partials 0 3874 +3874 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
…ogger-factory' into use-logger-factory # Conflicts: # platform-sdk/swirlds-logging-log4j-appender/src/main/java/com/swirlds/logging/log4j/factory/BaseLogger.java # platform-sdk/swirlds-logging-log4j-appender/src/main/java/com/swirlds/logging/log4j/factory/BaseLoggerContext.java # platform-sdk/swirlds-logging-log4j-appender/src/main/java/com/swirlds/logging/log4j/factory/BaseLoggerContextFactory.java # platform-sdk/swirlds-logging-log4j-appender/src/main/java/com/swirlds/logging/log4j/factory/BaseLoggingProvider.java # platform-sdk/swirlds-logging-log4j-appender/src/main/java/module-info.java
# Conflicts: # hedera-dependency-versions/build.gradle.kts # hedera-node/log4j2.xml
Description:
Related issue(s):
Fixes #
Notes for reviewer:
Checklist