Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move from Log4j Appender to Provider pattern (for performance tests) #13305

Draft
wants to merge 26 commits into
base: develop
Choose a base branch
from

Conversation

timo0
Copy link
Member

@timo0 timo0 commented May 15, 2024

Description:

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

timo0 added 8 commits May 8, 2024 14:04
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
Copy link

github-actions bot commented May 15, 2024

Node: HAPI Test (Restart) Results

2 tests   2 ✅  6m 33s ⏱️
2 suites  0 💤
2 files    0 ❌

Results for commit 0b6440b.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 15, 2024

Node: HAPI Test (Node Death Reconnect) Results

2 tests   0 ✅  0s ⏱️
2 suites  0 💤
2 files    2 ❌

For more details on these failures, see this check.

Results for commit 0876262.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 15, 2024

Node: HAPI Test (Token) Results

234 tests     0 ✅  0s ⏱️
 17 suites    2 💤
 17 files    232 ❌

For more details on these failures, see this check.

Results for commit 0876262.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 15, 2024

Node: HAPI Test (Crypto) Results

307 tests     0 ✅  1s ⏱️
 25 suites    0 💤
 25 files    307 ❌

For more details on these failures, see this check.

Results for commit 0876262.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 15, 2024

Node: HAPI Test (Time Consuming) Results

9 tests   0 ✅  0s ⏱️
3 suites  0 💤
3 files    9 ❌

For more details on these failures, see this check.

Results for commit 0876262.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 15, 2024

Node: HAPI Test (Smart Contract) Results

592 tests     0 ✅  1s ⏱️
 63 suites    0 💤
 63 files    592 ❌

For more details on these failures, see this check.

Results for commit 0876262.

♻️ This comment has been updated with latest results.

timo0 added 2 commits May 15, 2024 15:37
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
Copy link

github-actions bot commented May 15, 2024

Node: HAPI Test (Misc) Results

468 tests     0 ✅  2s ⏱️
 77 suites   10 💤
 77 files    458 ❌

For more details on these failures, see this check.

Results for commit 0876262.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 15, 2024

Node: Unit Test Results

  2 319 files  ±  0    2 319 suites  ±0   3h 16m 0s ⏱️ - 33m 11s
119 360 tests +309  119 236 ✅ +252  67 💤 ±0   57 ❌ + 57 
127 919 runs  +309  127 689 ✅ +146  67 💤 ±0  163 ❌ +163 

For more details on these failures, see this check.

Results for commit 0b6440b. ± Comparison against base commit 5b55935.

This pull request removes 4036 and adds 4109 tests. Note that renamed tests count towards both.

  
             IssuerDN: CN=s-aaaa
            SubjectDN: CN=s-aaaa
           Final Date: Fri Jan 01 00:00:00 UTC 2100
           Public Key: RSA Public Key [2e:28:bc:1e:d3:83:25:92:8e:cb:98:b1:b6:84:06:9c:d5:d8:14:d5],[56:66:d1:a4]
           Start Date: Sat Jan 01 00:00:00 UTC 2000
         SerialNumber: 12482092706667292405
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5…
   Address[id=0,nickname=BfOxk5aq,selfName=aaaa,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=17950,hostnameExternal=223.212.203.20,portExternalIpv4=17950,sigPublicKey=<null>,agreePublicKey=<null>,sigCert=com.swirlds.platform.crypto.SerializableX509Certificate@1e693678,agreeCert=com.swirlds.platform.crypto.SerializableX509Certificate@6238d55b,memo=WAHwpBR6],
…
com.hedera.hapi.node.transaction.tests.ResponseTest ‑ [7946] NoToStringWrapper{com.hedera.hapi.node.transaction.Response}
com.hedera.hapi.node.transaction.tests.ResponseTest ‑ [7947] NoToStringWrapper{com.hedera.hapi.node.transaction.Response}
com.hedera.hapi.node.transaction.tests.ResponseTest ‑ [7948] NoToStringWrapper{com.hedera.hapi.node.transaction.Response}
com.hedera.hapi.node.transaction.tests.ResponseTest ‑ [7949] NoToStringWrapper{com.hedera.hapi.node.transaction.Response}
com.hedera.hapi.node.transaction.tests.ResponseTest ‑ [7950] NoToStringWrapper{com.hedera.hapi.node.transaction.Response}
com.hedera.hapi.node.transaction.tests.ResponseTest ‑ [7951] NoToStringWrapper{com.hedera.hapi.node.transaction.Response}
com.hedera.hapi.node.transaction.tests.ResponseTest ‑ [7952] NoToStringWrapper{com.hedera.hapi.node.transaction.Response}
com.hedera.hapi.node.transaction.tests.ResponseTest ‑ [7953] NoToStringWrapper{com.hedera.hapi.node.transaction.Response}
com.hedera.hapi.node.transaction.tests.ResponseTest ‑ [7954] NoToStringWrapper{com.hedera.hapi.node.transaction.Response}
com.hedera.hapi.node.transaction.tests.ResponseTest ‑ [7955] NoToStringWrapper{com.hedera.hapi.node.transaction.Response}
…

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 47.42268% with 51 lines in your changes are missing coverage. Please review.

Project coverage is 61.76%. Comparing base (5b55935) to head (5c04b41).
Report is 1 commits behind head on develop.

Current head 5c04b41 differs from pull request most recent head 0b6440b

Please upload reports for the commit 0b6440b to get more accurate results.

Files Patch % Lines
.../com/swirlds/logging/log4j/factory/BaseLogger.java 44.26% 34 Missing ⚠️
...irlds/logging/log4j/factory/BaseLoggerContext.java 44.00% 11 Missing and 3 partials ⚠️
...ogging/log4j/factory/BaseLoggerContextFactory.java 50.00% 3 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##             develop   #13305       +/-   ##
==============================================
+ Coverage           0   61.76%   +61.76%     
- Complexity         0    31258    +31258     
==============================================
  Files              0     3446     +3446     
  Lines              0   141251   +141251     
  Branches           0    14780    +14780     
==============================================
+ Hits               0    87243    +87243     
- Misses             0    50134    +50134     
- Partials           0     3874     +3874     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timo0 timo0 changed the title Use logger factory chore: Move from Log4j Appender to Provider pattern May 17, 2024
@timo0 timo0 changed the title chore: Move from Log4j Appender to Provider pattern chore: Move from Log4j Appender to Provider pattern (for performance tests) May 17, 2024
timo0 added 9 commits May 17, 2024 11:49
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
timo0 added 7 commits May 22, 2024 08:25
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
…ogger-factory' into use-logger-factory

# Conflicts:
#	platform-sdk/swirlds-logging-log4j-appender/src/main/java/com/swirlds/logging/log4j/factory/BaseLogger.java
#	platform-sdk/swirlds-logging-log4j-appender/src/main/java/com/swirlds/logging/log4j/factory/BaseLoggerContext.java
#	platform-sdk/swirlds-logging-log4j-appender/src/main/java/com/swirlds/logging/log4j/factory/BaseLoggerContextFactory.java
#	platform-sdk/swirlds-logging-log4j-appender/src/main/java/com/swirlds/logging/log4j/factory/BaseLoggingProvider.java
#	platform-sdk/swirlds-logging-log4j-appender/src/main/java/module-info.java
# Conflicts:
#	hedera-dependency-versions/build.gradle.kts
#	hedera-node/log4j2.xml
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant