Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 13300 Added special handling for com.swirlds.platform.state.merkle.logging.StateLogger #13312

Merged
merged 2 commits into from
May 20, 2024

Conversation

imalygin
Copy link
Member

Description:

This PR addresses performance regression introduced by #12570

Now StateLogger has its own appenders.

Fixes #13300

poulok
poulok previously approved these changes May 15, 2024
Copy link

github-actions bot commented May 15, 2024

Node: HAPI Test (Restart) Results

2 tests   2 ✅  7m 49s ⏱️
2 suites  0 💤
2 files    0 ❌

Results for commit 4e3405f.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 15, 2024

Node: HAPI Test (Node Death Reconnect) Results

2 tests   2 ✅  10m 2s ⏱️
2 suites  0 💤
2 files    0 ❌

Results for commit 4e3405f.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 15, 2024

Node: HAPI Test (Token) Results

237 tests   235 ✅  20m 56s ⏱️
 17 suites    2 💤
 17 files      0 ❌

Results for commit 4e3405f.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 15, 2024

Node: HAPI Test (Crypto) Results

335 tests   335 ✅  39m 7s ⏱️
 25 suites    0 💤
 25 files      0 ❌

Results for commit 4e3405f.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 15, 2024

Node: HAPI Test (Misc) Results

468 tests   458 ✅  43m 15s ⏱️
 77 suites   10 💤
 77 files      0 ❌

Results for commit 4e3405f.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 15, 2024

Node: HAPI Test (Time Consuming) Results

21 tests   21 ✅  54m 10s ⏱️
 3 suites   0 💤
 3 files     0 ❌

Results for commit 4e3405f.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 15, 2024

Node: HAPI Test (Smart Contract) Results

604 tests   604 ✅  1h 16m 30s ⏱️
 63 suites    0 💤
 63 files      0 ❌

Results for commit 4e3405f.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 15, 2024

Node: Unit Test Results

  2 308 files  ±0    2 308 suites  ±0   3h 5m 28s ⏱️ + 1h 4m 32s
118 978 tests ±0  118 911 ✅ ±0  67 💤 ±0  0 ❌ ±0 
127 539 runs  ±0  127 472 ✅ ±0  67 💤 ±0  0 ❌ ±0 

Results for commit 4e3405f. ± Comparison against base commit 0e8eca1.

This pull request removes 4000 and adds 3763 tests. Note that renamed tests count towards both.

  
             IssuerDN: CN=s-aaaa
            SubjectDN: CN=s-aaaa
           Final Date: Fri Jan 01 00:00:00 UTC 2100
           Public Key: RSA Public Key [2e:28:bc:1e:d3:83:25:92:8e:cb:98:b1:b6:84:06:9c:d5:d8:14:d5],[56:66:d1:a4]
           Start Date: Sat Jan 01 00:00:00 UTC 2000
         SerialNumber: 12482092706667292405
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5e…
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5…
…
com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [4] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [6] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [7]   
  
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [10] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@86c0c97d
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [11] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@4801352a
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [12] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@23abdef4
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [13] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@cb0e4cfa
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [14] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@f30c71a7
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [15] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@43186246
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [16] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@f43ba860
…

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.73%. Comparing base (0e8eca1) to head (4e3405f).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop   #13312      +/-   ##
=============================================
- Coverage      61.74%   61.73%   -0.01%     
+ Complexity     31246    31242       -4     
=============================================
  Files           3446     3446              
  Lines         141291   141291              
  Branches       14781    14779       -2     
=============================================
- Hits           87234    87231       -3     
- Misses         50171    50173       +2     
- Partials        3886     3887       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…kle.logging.StateLogger`

Signed-off-by: Ivan Malygin <ivan@swirldslabs.com>
Signed-off-by: Ivan Malygin <ivan@swirldslabs.com>
Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tyvm @imalygin !

Copy link
Member

@Neeharika-Sompalli Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as per my understanding! Thanks @imalygin

Copy link
Member

@lukelee-sl lukelee-sl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thank you!

@poulok poulok merged commit 3889b94 into develop May 20, 2024
47 checks passed
@poulok poulok deleted the 13300-transaction-logger-fix branch May 20, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debug logging severely affects TPS
6 participants