-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 13300 Added special handling for com.swirlds.platform.state.merkle.logging.StateLogger
#13312
Conversation
Node: HAPI Test (Restart) Results2 tests 2 ✅ 7m 49s ⏱️ Results for commit 4e3405f. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Node Death Reconnect) Results2 tests 2 ✅ 10m 2s ⏱️ Results for commit 4e3405f. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Token) Results237 tests 235 ✅ 20m 56s ⏱️ Results for commit 4e3405f. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Crypto) Results335 tests 335 ✅ 39m 7s ⏱️ Results for commit 4e3405f. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Misc) Results468 tests 458 ✅ 43m 15s ⏱️ Results for commit 4e3405f. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Time Consuming) Results21 tests 21 ✅ 54m 10s ⏱️ Results for commit 4e3405f. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Smart Contract) Results604 tests 604 ✅ 1h 16m 30s ⏱️ Results for commit 4e3405f. ♻️ This comment has been updated with latest results. |
Node: Unit Test Results 2 308 files ±0 2 308 suites ±0 3h 5m 28s ⏱️ + 1h 4m 32s Results for commit 4e3405f. ± Comparison against base commit 0e8eca1. This pull request removes 4000 and adds 3763 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #13312 +/- ##
=============================================
- Coverage 61.74% 61.73% -0.01%
+ Complexity 31246 31242 -4
=============================================
Files 3446 3446
Lines 141291 141291
Branches 14781 14779 -2
=============================================
- Hits 87234 87231 -3
- Misses 50171 50173 +2
- Partials 3886 3887 +1 ☔ View full report in Codecov by Sentry. |
…kle.logging.StateLogger` Signed-off-by: Ivan Malygin <ivan@swirldslabs.com>
Signed-off-by: Ivan Malygin <ivan@swirldslabs.com>
b0acaeb
to
4e3405f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tyvm @imalygin !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as per my understanding! Thanks @imalygin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. thank you!
Description:
This PR addresses performance regression introduced by #12570
Now
StateLogger
has its own appenders.Fixes #13300