Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: test codacy #13314

Closed
wants to merge 2 commits into from
Closed

chore: test codacy #13314

wants to merge 2 commits into from

Conversation

povolev15
Copy link
Contributor

@povolev15 povolev15 commented May 15, 2024

Increase coverage to 100% for NetworkAdminServiceUtil
#13287

Signed-off-by: Lev Povolotsky <lev@swirldslabs.com>
Signed-off-by: Lev Povolotsky <lev@swirldslabs.com>
@povolev15 povolev15 self-assigned this May 15, 2024
@povolev15 povolev15 marked this pull request as ready for review May 15, 2024 16:44
@povolev15 povolev15 requested review from a team as code owners May 15, 2024 16:44
Copy link

Node: HAPI Test (Node Death Reconnect) Results

2 tests   2 ✅  10m 18s ⏱️
2 suites  0 💤
2 files    0 ❌

Results for commit 87b8706.

Copy link

Node: HAPI Test (Restart) Results

2 tests   2 ✅  9m 36s ⏱️
2 suites  0 💤
2 files    0 ❌

Results for commit 87b8706.

Copy link

Node: HAPI Test (Token) Results

237 tests   235 ✅  20m 21s ⏱️
 17 suites    2 💤
 17 files      0 ❌

Results for commit 87b8706.

Copy link

Node: HAPI Test (Misc) Results

468 tests   458 ✅  39m 30s ⏱️
 77 suites   10 💤
 77 files      0 ❌

Results for commit 87b8706.

Copy link

Node: HAPI Test (Crypto) Results

335 tests   335 ✅  40m 56s ⏱️
 25 suites    0 💤
 25 files      0 ❌

Results for commit 87b8706.

Copy link

Node: HAPI Test (Time Consuming) Results

21 tests   21 ✅  54m 24s ⏱️
 3 suites   0 💤
 3 files     0 ❌

Results for commit 87b8706.

Copy link

Node: HAPI Test (Smart Contract) Results

604 tests   604 ✅  1h 10m 28s ⏱️
 63 suites    0 💤
 63 files      0 ❌

Results for commit 87b8706.

Copy link

Node: Unit Test Results

  2 308 files  ±0    2 308 suites  ±0   3h 31m 32s ⏱️ + 1h 30m 36s
118 978 tests ±0  118 911 ✅ ±0  67 💤 ±0  0 ❌ ±0 
127 539 runs  ±0  127 472 ✅ ±0  67 💤 ±0  0 ❌ ±0 

Results for commit 87b8706. ± Comparison against base commit 0e8eca1.

This pull request removes 3985 and adds 3748 tests. Note that renamed tests count towards both.

  
             IssuerDN: CN=s-aaaa
            SubjectDN: CN=s-aaaa
           Final Date: Fri Jan 01 00:00:00 UTC 2100
           Public Key: RSA Public Key [2e:28:bc:1e:d3:83:25:92:8e:cb:98:b1:b6:84:06:9c:d5:d8:14:d5],[56:66:d1:a4]
           Start Date: Sat Jan 01 00:00:00 UTC 2000
         SerialNumber: 12482092706667292405
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5e…
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5…
…
com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [4] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [6] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [7]   
  
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [10] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@d6c05ae0
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [11] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@4006fe93
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [12] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@eedcc068
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [13] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@33c072ba
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [14] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@a59b0070
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [15] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@e19ce52d
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [16] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@f2ac7297
…

Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.74%. Comparing base (0e8eca1) to head (87b8706).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop   #13314      +/-   ##
=============================================
- Coverage      61.74%   61.74%   -0.01%     
+ Complexity     31246    31244       -2     
=============================================
  Files           3446     3446              
  Lines         141291   141289       -2     
  Branches       14781    14779       -2     
=============================================
- Hits           87234    87232       -2     
  Misses         50171    50171              
  Partials        3886     3886              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@derektriley derektriley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Perhaps update the PR title.

@povolev15 povolev15 closed this May 28, 2024
@povolev15
Copy link
Contributor Author

testing codacy coverage when remove private construction impl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants