-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: test codacy #13314
chore: test codacy #13314
Conversation
Signed-off-by: Lev Povolotsky <lev@swirldslabs.com>
Signed-off-by: Lev Povolotsky <lev@swirldslabs.com>
Node: HAPI Test (Node Death Reconnect) Results2 tests 2 ✅ 10m 18s ⏱️ Results for commit 87b8706. |
Node: HAPI Test (Restart) Results2 tests 2 ✅ 9m 36s ⏱️ Results for commit 87b8706. |
Node: HAPI Test (Token) Results237 tests 235 ✅ 20m 21s ⏱️ Results for commit 87b8706. |
Node: HAPI Test (Misc) Results468 tests 458 ✅ 39m 30s ⏱️ Results for commit 87b8706. |
Node: HAPI Test (Crypto) Results335 tests 335 ✅ 40m 56s ⏱️ Results for commit 87b8706. |
Node: HAPI Test (Time Consuming) Results21 tests 21 ✅ 54m 24s ⏱️ Results for commit 87b8706. |
Node: HAPI Test (Smart Contract) Results604 tests 604 ✅ 1h 10m 28s ⏱️ Results for commit 87b8706. |
Node: Unit Test Results 2 308 files ±0 2 308 suites ±0 3h 31m 32s ⏱️ + 1h 30m 36s Results for commit 87b8706. ± Comparison against base commit 0e8eca1. This pull request removes 3985 and adds 3748 tests. Note that renamed tests count towards both.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #13314 +/- ##
=============================================
- Coverage 61.74% 61.74% -0.01%
+ Complexity 31246 31244 -2
=============================================
Files 3446 3446
Lines 141291 141289 -2
Branches 14781 14779 -2
=============================================
- Hits 87234 87232 -2
Misses 50171 50171
Partials 3886 3886 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Perhaps update the PR title.
testing codacy coverage when remove private construction impl |
Increase coverage to 100% for NetworkAdminServiceUtil
#13287