-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement v0.51 evm module and HAS functions #13326
Conversation
Signed-off-by: lukelee-sl <luke.lee@swirldslabs.com>
…into 13136-has-base-implementation
Signed-off-by: lukelee-sl <luke.lee@swirldslabs.com>
…pt through the proxy Signed-off-by: lukelee-sl <luke.lee@swirldslabs.com>
…into 13181-evm-v-51-updates
Signed-off-by: lukelee-sl <luke.lee@swirldslabs.com>
Node: HAPI Test (Misc) Results468 tests 458 ✅ 40m 19s ⏱️ Results for commit f7868ff. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Restart) Results2 tests 2 ✅ 8m 33s ⏱️ Results for commit f7868ff. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Node Death Reconnect) Results2 tests 2 ✅ 9m 26s ⏱️ Results for commit f7868ff. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Smart Contract) Results604 tests 604 ✅ 1h 9m 47s ⏱️ Results for commit f7868ff. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Crypto) Results335 tests 335 ✅ 41m 20s ⏱️ Results for commit f7868ff. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Token) Results237 tests 235 ✅ 20m 35s ⏱️ Results for commit f7868ff. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Time Consuming) Results21 tests 21 ✅ 54m 28s ⏱️ Results for commit f7868ff. ♻️ This comment has been updated with latest results. |
Node: Unit Test Results 2 315 files + 7 2 315 suites +7 3h 26m 54s ⏱️ - 2m 22s Results for commit f7868ff. ± Comparison against base commit dc3d3ae. This pull request removes 3998 and adds 3789 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #13326 +/- ##
=============================================
+ Coverage 61.74% 61.77% +0.03%
- Complexity 31248 31299 +51
=============================================
Files 3446 3453 +7
Lines 141289 141443 +154
Branches 14779 14791 +12
=============================================
+ Hits 87233 87377 +144
- Misses 50170 50173 +3
- Partials 3886 3893 +7 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At this point I've just checked the plumbing which looks fine.
Still to do: The 4 key classes Hbar{Allowance|Approve}{Call|Translator}
and the tests.
...-service-impl/src/main/java/com/hedera/node/app/service/contract/impl/exec/FeatureFlags.java
Outdated
Show resolved
Hide resolved
hedera-node/hedera-config/src/main/java/com/hedera/node/config/data/ContractsConfig.java
Outdated
Show resolved
Hide resolved
hedera-node/hedera-app/src/xtest/java/contract/AbstractContractXTest.java
Show resolved
Hide resolved
...t-service-impl/src/test/java/com/hedera/node/app/service/contract/impl/test/TestHelpers.java
Show resolved
Hide resolved
...m/hedera/node/app/service/contract/impl/test/exec/systemcontracts/HasSystemContractTest.java
Show resolved
Hide resolved
.../hedera/node/app/service/contract/impl/test/exec/systemcontracts/has/HasCallAttemptTest.java
Show resolved
Hide resolved
Signed-off-by: lukelee-sl <luke.lee@swirldslabs.com>
…into 13181-evm-v-51-updates
Signed-off-by: lukelee-sl <luke.lee@swirldslabs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, ty @lukelee-sl !
Description:
Third in the series of tasks for HIP-906.
hbarAllowance
andhbarApprove
function calls in the Hedera Account Service system contract.Related issue(s):
Fixes #13181
Notes for reviewer:
xTests will be forthcoming in a future pr.
Substituting the
redirectForAccount
proxy contract byte code will also be in the next pr.Most of the new logic is centered around
hbarAllowanceTranslator
,hbarAllowanceCall
,hbarApproveTranslator
andhbarApproveCall
Checklist