-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: signed state file manager wiring cleanup #13330
Conversation
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Node: HAPI Test (Restart) Results2 tests 2 ✅ 8m 11s ⏱️ Results for commit e6d92e1. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Node Death Reconnect) Results2 tests 2 ✅ 8m 55s ⏱️ Results for commit e6d92e1. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Token) Results237 tests 235 ✅ 19m 54s ⏱️ Results for commit e6d92e1. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Crypto) Results335 tests 335 ✅ 41m 46s ⏱️ Results for commit e6d92e1. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Misc) Results468 tests 458 ✅ 44m 27s ⏱️ Results for commit e6d92e1. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Time Consuming) Results21 tests 21 ✅ 54m 6s ⏱️ Results for commit e6d92e1. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Smart Contract) Results604 tests 603 ✅ 1h 12m 17s ⏱️ For more details on these failures, see this check. Results for commit e6d92e1. ♻️ This comment has been updated with latest results. |
Node: Unit Test Results 2 308 files ± 0 2 308 suites ±0 3h 12m 52s ⏱️ - 16m 24s Results for commit e6d92e1. ± Comparison against base commit dc3d3ae. This pull request removes 4010 and adds 3797 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #13330 +/- ##
=============================================
+ Coverage 61.74% 67.32% +5.58%
- Complexity 31248 36181 +4933
=============================================
Files 3446 3695 +249
Lines 141289 148871 +7582
Branches 14779 15489 +710
=============================================
+ Hits 87233 100225 +12992
+ Misses 50170 44291 -5879
- Partials 3886 4355 +469 ☔ View full report in Codecov by Sentry. |
...irlds-platform-core/src/main/java/com/swirlds/platform/builder/PlatformComponentBuilder.java
Outdated
Show resolved
Hide resolved
...irlds-platform-core/src/main/java/com/swirlds/platform/builder/PlatformComponentBuilder.java
Outdated
Show resolved
Hide resolved
...m-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/state/SwirldStateManager.java
Outdated
Show resolved
Hide resolved
...form-core/src/main/java/com/swirlds/platform/state/snapshot/DefaultStateSnapshotManager.java
Show resolved
Hide resolved
...form-core/src/main/java/com/swirlds/platform/state/snapshot/StateSnapshotManagerMetrics.java
Outdated
Show resolved
Hide resolved
...form-core/src/main/java/com/swirlds/platform/state/snapshot/StateSnapshotManagerMetrics.java
Show resolved
Hide resolved
Signed-off-by: Cody Littley <cody@swirldslabs.com>
I think package name changes that cause lots of files to be changed should be independent PRs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
closes #13323