Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: signed state file manager wiring cleanup #13330

Merged
merged 3 commits into from
May 20, 2024
Merged

Conversation

cody-littley
Copy link
Contributor

closes #13323

Signed-off-by: Cody Littley <cody@swirldslabs.com>
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley cody-littley added this to the v0.51 milestone May 15, 2024
@cody-littley cody-littley self-assigned this May 15, 2024
@cody-littley cody-littley requested review from a team as code owners May 15, 2024 19:56
@cody-littley cody-littley changed the title 13323 ssfm wiring feat: signed state file manager wiring cleanup May 15, 2024
Copy link

github-actions bot commented May 15, 2024

Node: HAPI Test (Restart) Results

2 tests   2 ✅  8m 11s ⏱️
2 suites  0 💤
2 files    0 ❌

Results for commit e6d92e1.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 15, 2024

Node: HAPI Test (Node Death Reconnect) Results

2 tests   2 ✅  8m 55s ⏱️
2 suites  0 💤
2 files    0 ❌

Results for commit e6d92e1.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 15, 2024

Node: HAPI Test (Token) Results

237 tests   235 ✅  19m 54s ⏱️
 17 suites    2 💤
 17 files      0 ❌

Results for commit e6d92e1.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 15, 2024

Node: HAPI Test (Crypto) Results

335 tests   335 ✅  41m 46s ⏱️
 25 suites    0 💤
 25 files      0 ❌

Results for commit e6d92e1.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 15, 2024

Node: HAPI Test (Misc) Results

468 tests   458 ✅  44m 27s ⏱️
 77 suites   10 💤
 77 files      0 ❌

Results for commit e6d92e1.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 15, 2024

Node: HAPI Test (Time Consuming) Results

21 tests   21 ✅  54m 6s ⏱️
 3 suites   0 💤
 3 files     0 ❌

Results for commit e6d92e1.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 15, 2024

Node: HAPI Test (Smart Contract) Results

604 tests   603 ✅  1h 12m 17s ⏱️
 63 suites    0 💤
 63 files      1 ❌

For more details on these failures, see this check.

Results for commit e6d92e1.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 15, 2024

Node: Unit Test Results

  2 308 files  ± 0    2 308 suites  ±0   3h 12m 52s ⏱️ - 16m 24s
119 001 tests +23  118 934 ✅ +23  67 💤 ±0  0 ❌ ±0 
127 562 runs  +23  127 495 ✅ +23  67 💤 ±0  0 ❌ ±0 

Results for commit e6d92e1. ± Comparison against base commit dc3d3ae.

This pull request removes 4010 and adds 3797 tests. Note that renamed tests count towards both.

  
             IssuerDN: CN=s-aaaa
            SubjectDN: CN=s-aaaa
           Final Date: Fri Jan 01 00:00:00 UTC 2100
           Public Key: RSA Public Key [2e:28:bc:1e:d3:83:25:92:8e:cb:98:b1:b6:84:06:9c:d5:d8:14:d5],[56:66:d1:a4]
           Start Date: Sat Jan 01 00:00:00 UTC 2000
         SerialNumber: 12482092706667292405
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5e…
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5…
…
com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [4] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [6] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [7]   
  
com.hedera.node.app.service.file.impl.test.FileServiceImplTest ‑ testSetFs()
com.hedera.node.app.service.file.impl.test.handlers.FileDeleteTest ‑ calculateFees method invocations
com.hedera.node.app.service.file.impl.test.handlers.FileDeleteTest ‑ pureChecks does not throw exception when file id is not null
com.hedera.node.app.service.file.impl.test.handlers.FileDeleteTest ‑ pureChecks throws exception when file id is null
com.hedera.node.app.service.file.impl.test.handlers.FileSignatureWaiversImplTest ‑ Signatures are not waived when payer does not have privileged authorization
com.hedera.node.app.service.file.impl.test.handlers.FileSignatureWaiversImplTest ‑ Signatures are waived when payer has privileged authorization
com.hedera.node.app.service.file.impl.test.handlers.FileSystemUndeleteTest ‑ calculateFees method invocations
…

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 71.66667% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 67.32%. Comparing base (dc3d3ae) to head (e6d92e1).
Report is 21 commits behind head on develop.

Files Patch % Lines
...lds/platform/builder/PlatformComponentBuilder.java 33.33% 6 Missing and 2 partials ⚠️
...va/com/swirlds/platform/wiring/PlatformWiring.java 75.00% 5 Missing ⚠️
.../platform/state/snapshot/StateSnapshotManager.java 0.00% 4 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop   #13330      +/-   ##
=============================================
+ Coverage      61.74%   67.32%   +5.58%     
- Complexity     31248    36181    +4933     
=============================================
  Files           3446     3695     +249     
  Lines         141289   148871    +7582     
  Branches       14779    15489     +710     
=============================================
+ Hits           87233   100225   +12992     
+ Misses         50170    44291    -5879     
- Partials        3886     4355     +469     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Cody Littley <cody@swirldslabs.com>
@lpetrovic05
Copy link
Member

I think package name changes that cause lots of files to be changed should be independent PRs

Copy link
Member

@Neeharika-Sompalli Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cody-littley cody-littley merged commit b86dab5 into develop May 20, 2024
45 of 48 checks passed
@cody-littley cody-littley deleted the 13323-ssfm-wiring branch May 20, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve signed state file manager wiring
5 participants