Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add test coverage for UnzipUtility and NetworkUncheckedSubmitHandler #13351

Merged

Conversation

thomas-swirlds-labs
Copy link
Contributor

Description:

Add test coverage for UnzipUtility and NetworkUncheckedSubmitHandler and remove Jupiter Assertions

Related issue(s):

Fixes #13272

Signed-off-by: Thomas Moran <152873392+thomas-swirlds-labs@users.noreply.github.com>
@thomas-swirlds-labs thomas-swirlds-labs self-assigned this May 16, 2024
Signed-off-by: Thomas Moran <152873392+thomas-swirlds-labs@users.noreply.github.com>
Copy link

github-actions bot commented May 16, 2024

Node: Unit Test Results

  2 309 files    2 309 suites   3h 14m 15s ⏱️
119 012 tests 118 945 ✅ 67 💤 0 ❌
127 573 runs  127 506 ✅ 67 💤 0 ❌

Results for commit e1069ad.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.34%. Comparing base (32c6bbb) to head (e1069ad).
Report is 7 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop   #13351      +/-   ##
=============================================
+ Coverage      67.21%   67.34%   +0.12%     
- Complexity     36161    36201      +40     
=============================================
  Files           3700     3700              
  Lines         148961   148962       +1     
  Branches       15501    15499       -2     
=============================================
+ Hits          100126   100320     +194     
+ Misses         44505    44290     -215     
- Partials        4330     4352      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented May 16, 2024

Node: HAPI Test (Restart) Results

2 tests   2 ✅  7m 52s ⏱️
2 suites  0 💤
2 files    0 ❌

Results for commit e1069ad.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 16, 2024

Node: HAPI Test (Node Death Reconnect) Results

2 tests   2 ✅  9m 4s ⏱️
2 suites  0 💤
2 files    0 ❌

Results for commit e1069ad.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 16, 2024

Node: HAPI Test (Token) Results

237 tests   235 ✅  20m 32s ⏱️
 17 suites    2 💤
 17 files      0 ❌

Results for commit e1069ad.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 16, 2024

Node: HAPI Test (Misc) Results

468 tests   457 ✅  42m 38s ⏱️
 77 suites   10 💤
 77 files      1 ❌

For more details on these failures, see this check.

Results for commit e1069ad.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 16, 2024

Node: HAPI Test (Crypto) Results

335 tests   335 ✅  39m 29s ⏱️
 25 suites    0 💤
 25 files      0 ❌

Results for commit e1069ad.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 16, 2024

Node: HAPI Test (Time Consuming) Results

21 tests   21 ✅  54m 20s ⏱️
 3 suites   0 💤
 3 files     0 ❌

Results for commit e1069ad.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 16, 2024

Node: HAPI Test (Smart Contract) Results

604 tests   604 ✅  1h 14m 2s ⏱️
 63 suites    0 💤
 63 files      0 ❌

Results for commit e1069ad.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@derektriley derektriley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@thomas-swirlds-labs thomas-swirlds-labs merged commit 4761f79 into develop May 17, 2024
44 of 47 checks passed
@thomas-swirlds-labs thomas-swirlds-labs deleted the 13272-coverage-for-NetworkUncheckedSubmitHandler branch May 17, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NetworkAdmin Service Handlers > 80%
2 participants