-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add test coverage for UnzipUtility and NetworkUncheckedSubmitHandler #13351
chore: Add test coverage for UnzipUtility and NetworkUncheckedSubmitHandler #13351
Conversation
Signed-off-by: Thomas Moran <152873392+thomas-swirlds-labs@users.noreply.github.com>
Signed-off-by: Thomas Moran <152873392+thomas-swirlds-labs@users.noreply.github.com>
Node: Unit Test Results 2 309 files 2 309 suites 3h 14m 15s ⏱️ Results for commit e1069ad. ♻️ This comment has been updated with latest results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #13351 +/- ##
=============================================
+ Coverage 67.21% 67.34% +0.12%
- Complexity 36161 36201 +40
=============================================
Files 3700 3700
Lines 148961 148962 +1
Branches 15501 15499 -2
=============================================
+ Hits 100126 100320 +194
+ Misses 44505 44290 -215
- Partials 4330 4352 +22 ☔ View full report in Codecov by Sentry. |
Node: HAPI Test (Restart) Results2 tests 2 ✅ 7m 52s ⏱️ Results for commit e1069ad. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Node Death Reconnect) Results2 tests 2 ✅ 9m 4s ⏱️ Results for commit e1069ad. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Token) Results237 tests 235 ✅ 20m 32s ⏱️ Results for commit e1069ad. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Misc) Results468 tests 457 ✅ 42m 38s ⏱️ For more details on these failures, see this check. Results for commit e1069ad. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Crypto) Results335 tests 335 ✅ 39m 29s ⏱️ Results for commit e1069ad. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Time Consuming) Results21 tests 21 ✅ 54m 20s ⏱️ Results for commit e1069ad. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Smart Contract) Results604 tests 604 ✅ 1h 14m 2s ⏱️ Results for commit e1069ad. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Description:
Add test coverage for UnzipUtility and NetworkUncheckedSubmitHandler and remove Jupiter Assertions
Related issue(s):
Fixes #13272