-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: apps provide a PBJ software version #13353
feat: apps provide a PBJ software version #13353
Conversation
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
Node: HAPI Test (Node Death Reconnect) Results2 tests 2 ✅ 8m 46s ⏱️ Results for commit 1599b6e. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Restart) Results2 tests 2 ✅ 7m 45s ⏱️ Results for commit 1599b6e. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Token) Results237 tests 235 ✅ 19m 18s ⏱️ Results for commit 1599b6e. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Misc) Results468 tests 457 ✅ 41m 18s ⏱️ For more details on these failures, see this check. Results for commit 1599b6e. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Time Consuming) Results21 tests 21 ✅ 53m 46s ⏱️ Results for commit 1599b6e. ♻️ This comment has been updated with latest results. |
Node: Unit Test Results 2 319 files +10 2 319 suites +10 3h 15m 1s ⏱️ - 17m 16s Results for commit 1599b6e. ± Comparison against base commit 32c6bbb. This pull request removes 4010 and adds 3838 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #13353 +/- ##
=============================================
- Coverage 67.21% 66.45% -0.76%
+ Complexity 36161 35827 -334
=============================================
Files 3700 3700
Lines 148961 148971 +10
Branches 15501 15501
=============================================
- Hits 100126 99004 -1122
- Misses 44505 45670 +1165
+ Partials 4330 4297 -33 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
Node: HAPI Test (Crypto) Results335 tests 335 ✅ 40m 5s ⏱️ Results for commit 1599b6e. |
Node: HAPI Test (Smart Contract) Results605 tests 605 ✅ 1h 9m 39s ⏱️ Results for commit 1599b6e. |
...orm-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/system/SoftwareVersion.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! Thanks @lpetrovic05
closes #13431