Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: apps provide a PBJ software version #13353

Merged
merged 6 commits into from
May 22, 2024

Conversation

lpetrovic05
Copy link
Member

@lpetrovic05 lpetrovic05 commented May 16, 2024

closes #13431

Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
Copy link

github-actions bot commented May 16, 2024

Node: HAPI Test (Node Death Reconnect) Results

2 tests   2 ✅  8m 46s ⏱️
2 suites  0 💤
2 files    0 ❌

Results for commit 1599b6e.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 16, 2024

Node: HAPI Test (Restart) Results

2 tests   2 ✅  7m 45s ⏱️
2 suites  0 💤
2 files    0 ❌

Results for commit 1599b6e.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 16, 2024

Node: HAPI Test (Token) Results

237 tests   235 ✅  19m 18s ⏱️
 17 suites    2 💤
 17 files      0 ❌

Results for commit 1599b6e.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 16, 2024

Node: HAPI Test (Misc) Results

468 tests   457 ✅  41m 18s ⏱️
 77 suites   10 💤
 77 files      1 ❌

For more details on these failures, see this check.

Results for commit 1599b6e.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 16, 2024

Node: HAPI Test (Time Consuming) Results

21 tests   21 ✅  53m 46s ⏱️
 3 suites   0 💤
 3 files     0 ❌

Results for commit 1599b6e.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 16, 2024

Node: Unit Test Results

  2 319 files  +10    2 319 suites  +10   3h 15m 1s ⏱️ - 17m 16s
119 058 tests +63  118 991 ✅ +63  67 💤 ±0  0 ❌ ±0 
127 619 runs  +63  127 552 ✅ +63  67 💤 ±0  0 ❌ ±0 

Results for commit 1599b6e. ± Comparison against base commit 32c6bbb.

This pull request removes 4010 and adds 3838 tests. Note that renamed tests count towards both.

  
             IssuerDN: CN=s-aaaa
            SubjectDN: CN=s-aaaa
           Final Date: Fri Jan 01 00:00:00 UTC 2100
           Public Key: RSA Public Key [2e:28:bc:1e:d3:83:25:92:8e:cb:98:b1:b6:84:06:9c:d5:d8:14:d5],[56:66:d1:a4]
           Start Date: Sat Jan 01 00:00:00 UTC 2000
         SerialNumber: 12482092706667292405
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5…
   Address[id=0,nickname=7Nt1ZPfO,selfName=aaaa,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=33788,hostnameExternal=136.70.147.145,portExternalIpv4=33788,sigPublicKey=<null>,agreePublicKey=<null>,sigCert=com.swirlds.platform.crypto.SerializableX509Certificate@2f188eec,agreeCert=com.swirlds.platform.crypto.SerializableX509Certificate@584606ce,memo=XoXfcwxW],
…
com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [4] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [6] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [7]   
  
com.hedera.node.app.service.contract.impl.test.exec.systemcontracts.HasSystemContractTest ‑ haltsAndConsumesRemainingGasIfConfigIsOff()
com.hedera.node.app.service.contract.impl.test.exec.systemcontracts.has.HasCallAttemptTest ‑ constructsHbarAllowanceDirect()
com.hedera.node.app.service.contract.impl.test.exec.systemcontracts.has.HasCallAttemptTest ‑ constructsHbarAllowanceProxy()
com.hedera.node.app.service.contract.impl.test.exec.systemcontracts.has.HasCallAttemptTest ‑ constructsHbarApproveDirect()
com.hedera.node.app.service.contract.impl.test.exec.systemcontracts.has.HasCallAttemptTest ‑ constructsHbarApproveProxy()
com.hedera.node.app.service.contract.impl.test.exec.systemcontracts.has.HasCallAttemptTest ‑ invalidSelectorLeadsToMissingCall()
com.hedera.node.app.service.contract.impl.test.exec.systemcontracts.has.HasCallAttemptTest ‑ returnNullAccountIfAccountNotFound()
…

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 66.45%. Comparing base (32c6bbb) to head (f1be612).
Report is 15 commits behind head on develop.

Current head f1be612 differs from pull request most recent head 1599b6e

Please upload reports for the commit 1599b6e to get more accurate results.

Files Patch % Lines
...e/mono/context/properties/SerializableSemVers.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop   #13353      +/-   ##
=============================================
- Coverage      67.21%   66.45%   -0.76%     
+ Complexity     36161    35827     -334     
=============================================
  Files           3700     3700              
  Lines         148961   148971      +10     
  Branches       15501    15501              
=============================================
- Hits          100126    99004    -1122     
- Misses         44505    45670    +1165     
+ Partials        4330     4297      -33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

alittley
alittley previously approved these changes May 17, 2024
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
Copy link

Node: HAPI Test (Crypto) Results

335 tests   335 ✅  40m 5s ⏱️
 25 suites    0 💤
 25 files      0 ❌

Results for commit 1599b6e.

Copy link

Node: HAPI Test (Smart Contract) Results

605 tests   605 ✅  1h 9m 39s ⏱️
 63 suites    0 💤
 63 files      0 ❌

Results for commit 1599b6e.

Copy link
Member

@mhess-swl mhess-swl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Neeharika-Sompalli Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Thanks @lpetrovic05

@lpetrovic05 lpetrovic05 merged commit 09940c2 into develop May 22, 2024
45 of 48 checks passed
@lpetrovic05 lpetrovic05 deleted the 13344-D-apps-should-provide-PBJ-sofware-version branch May 22, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add PBJ version to apps
4 participants