-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: TokenPauseHandler increase unit test coverage #13362
Conversation
Signed-off-by: Derek Riley <derek.riley@swirldslabs.com>
Node: Unit Test Results 2 312 files ±0 2 312 suites ±0 3h 18m 4s ⏱️ - 2m 47s Results for commit d14a7ee. ± Comparison against base commit 73712b1. This pull request removes 357 and adds 124 tests. Note that renamed tests count towards both.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #13362 +/- ##
==========================================
Coverage 67.38% 67.39%
- Complexity 36210 36213 +3
==========================================
Files 3700 3700
Lines 148964 148964
Branches 15499 15499
==========================================
+ Hits 100378 100387 +9
+ Misses 44223 44214 -9
Partials 4363 4363 ☔ View full report in Codecov by Sentry. |
Node: HAPI Test (Restart) Results2 tests 2 ✅ 8m 12s ⏱️ Results for commit d14a7ee. |
Node: HAPI Test (Node Death Reconnect) Results2 tests 2 ✅ 9m 23s ⏱️ Results for commit d14a7ee. |
Node: HAPI Test (Token) Results237 tests 235 ✅ 21m 9s ⏱️ Results for commit d14a7ee. |
Node: HAPI Test (Crypto) Results335 tests 335 ✅ 37m 36s ⏱️ Results for commit d14a7ee. |
Node: HAPI Test (Misc) Results468 tests 458 ✅ 41m 1s ⏱️ Results for commit d14a7ee. |
Node: HAPI Test (Time Consuming) Results21 tests 21 ✅ 54m 4s ⏱️ Results for commit d14a7ee. |
Node: HAPI Test (Smart Contract) Results604 tests 604 ✅ 1h 17m 11s ⏱️ Results for commit d14a7ee. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM TY @derektriley
Description:
Adds unit tests for pureChecks and calculateFees. Increases coverage to 100%.
Related issue(s):
#13355
Notes for reviewer:
Checklist