-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: TokenUnpauseHandler increase unit test coverage #13364
Conversation
Signed-off-by: Derek Riley <derek.riley@swirldslabs.com>
Node: HAPI Test (Node Death Reconnect) Results2 tests 2 ✅ 9m 23s ⏱️ Results for commit 412c5a1. |
Node: HAPI Test (Restart) Results2 tests 2 ✅ 8m 12s ⏱️ Results for commit 412c5a1. |
Node: Unit Test Results 2 312 files ±0 2 312 suites ±0 3h 18m 15s ⏱️ - 2m 36s Results for commit 412c5a1. ± Comparison against base commit 73712b1. This pull request removes 357 and adds 124 tests. Note that renamed tests count towards both.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #13364 +/- ##
==========================================
Coverage 67.38% 67.39%
- Complexity 36210 36213 +3
==========================================
Files 3700 3700
Lines 148964 148964
Branches 15499 15499
==========================================
+ Hits 100378 100387 +9
+ Misses 44223 44214 -9
Partials 4363 4363 ☔ View full report in Codecov by Sentry. |
Node: HAPI Test (Token) Results237 tests 235 ✅ 24m 48s ⏱️ Results for commit 412c5a1. |
Node: HAPI Test (Crypto) Results335 tests 335 ✅ 37m 14s ⏱️ Results for commit 412c5a1. |
Node: HAPI Test (Misc) Results468 tests 458 ✅ 46m 8s ⏱️ Results for commit 412c5a1. |
Node: HAPI Test (Time Consuming) Results21 tests 21 ✅ 54m 23s ⏱️ Results for commit 412c5a1. |
Node: HAPI Test (Smart Contract) Results604 tests 604 ✅ 1h 9m 16s ⏱️ Results for commit 412c5a1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM TY @derektriley
Description:
Adds unit tests for pureChecks and calculateFees. Increases coverage to 100%.
Related issue(s):
#13356
Notes for reviewer:
Checklist