-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add InitialModServiceAdminSchema test coverage #13365
chore: add InitialModServiceAdminSchema test coverage #13365
Conversation
Signed-off-by: Lev Povolotsky <lev@swirldslabs.com>
Signed-off-by: Lev Povolotsky <lev@swirldslabs.com>
Node: HAPI Test (Restart) Results2 tests 2 ✅ 8m 3s ⏱️ Results for commit 4ed37b5. |
Node: HAPI Test (Node Death Reconnect) Results2 tests 2 ✅ 8m 58s ⏱️ Results for commit 4ed37b5. |
Node: HAPI Test (Token) Results237 tests 235 ✅ 21m 26s ⏱️ Results for commit 4ed37b5. |
Node: HAPI Test (Crypto) Results335 tests 335 ✅ 40m 36s ⏱️ Results for commit 4ed37b5. |
Node: HAPI Test (Misc) Results468 tests 457 ✅ 41m 43s ⏱️ For more details on these failures, see this check. Results for commit 4ed37b5. |
Node: Unit Test Results 2 313 files +1 2 313 suites +1 3h 9m 23s ⏱️ -31s Results for commit 4ed37b5. ± Comparison against base commit ce6f299. This pull request removes 357 and adds 123 tests. Note that renamed tests count towards both.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #13365 +/- ##
=============================================
- Coverage 67.39% 67.39% -0.01%
- Complexity 36216 36217 +1
=============================================
Files 3701 3701
Lines 148961 148961
Branches 15500 15500
=============================================
- Hits 100391 100387 -4
- Misses 44220 44222 +2
- Partials 4350 4352 +2 ☔ View full report in Codecov by Sentry. |
Node: HAPI Test (Time Consuming) Results21 tests 21 ✅ 54m 36s ⏱️ Results for commit 4ed37b5. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Node: HAPI Test (Smart Contract) Results604 tests 604 ✅ 1h 12m 30s ⏱️ Results for commit 4ed37b5. |
InitialModServiceAdminSchema test coverage 100%
Related issue(s):
Fixes #13293