Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add InitialModServiceAdminSchema test coverage #13365

Merged
merged 2 commits into from
May 20, 2024

Conversation

povolev15
Copy link
Contributor

InitialModServiceAdminSchema test coverage 100%

Related issue(s):

Fixes #13293

Signed-off-by: Lev Povolotsky <lev@swirldslabs.com>
@povolev15 povolev15 self-assigned this May 16, 2024
@povolev15 povolev15 marked this pull request as ready for review May 16, 2024 19:36
@povolev15 povolev15 requested review from a team as code owners May 16, 2024 19:36
Signed-off-by: Lev Povolotsky <lev@swirldslabs.com>
Copy link

Node: HAPI Test (Restart) Results

2 tests   2 ✅  8m 3s ⏱️
2 suites  0 💤
2 files    0 ❌

Results for commit 4ed37b5.

Copy link

Node: HAPI Test (Node Death Reconnect) Results

2 tests   2 ✅  8m 58s ⏱️
2 suites  0 💤
2 files    0 ❌

Results for commit 4ed37b5.

Copy link

Node: HAPI Test (Token) Results

237 tests   235 ✅  21m 26s ⏱️
 17 suites    2 💤
 17 files      0 ❌

Results for commit 4ed37b5.

Copy link

Node: HAPI Test (Crypto) Results

335 tests   335 ✅  40m 36s ⏱️
 25 suites    0 💤
 25 files      0 ❌

Results for commit 4ed37b5.

Copy link

Node: HAPI Test (Misc) Results

468 tests   457 ✅  41m 43s ⏱️
 77 suites   10 💤
 77 files      1 ❌

For more details on these failures, see this check.

Results for commit 4ed37b5.

Copy link

Node: Unit Test Results

  2 313 files  +1    2 313 suites  +1   3h 9m 23s ⏱️ -31s
119 029 tests +2  118 962 ✅ +2  67 💤 ±0  0 ❌ ±0 
127 590 runs  +2  127 523 ✅ +2  67 💤 ±0  0 ❌ ±0 

Results for commit 4ed37b5. ± Comparison against base commit ce6f299.

This pull request removes 357 and adds 123 tests. Note that renamed tests count towards both.

  
             IssuerDN: CN=s-aaaa
            SubjectDN: CN=s-aaaa
           Final Date: Fri Jan 01 00:00:00 UTC 2100
           Public Key: RSA Public Key [2e:28:bc:1e:d3:83:25:92:8e:cb:98:b1:b6:84:06:9c:d5:d8:14:d5],[56:66:d1:a4]
           Start Date: Sat Jan 01 00:00:00 UTC 2000
         SerialNumber: 12482092706667292405
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5e…
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5…
…
com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [4] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [6] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [7]   
  
com.hedera.node.app.service.networkadmin.impl.test.schemas.InitialModServiceAdminSchemaTest ‑ registersExpectedSchema()
com.hedera.node.app.service.networkadmin.impl.test.schemas.InitialModServiceAdminSchemaTest ‑ setFSasExpectedAndHappyPathMigration()
com.hedera.node.app.state.merkle.StateMetadataTest ‑ [11] 

com.hedera.node.app.state.merkle.StateMetadataTest ‑ [203] Some Legal Characters 

com.hedera.node.app.state.merkle.StateMetadataTest ‑ [395] 
 Some Legal Characters
com.swirlds.platform.crypto.KeysAndCertsTest ‑ [1] AddressBook {
   Address[id=0,nickname=0hdR11Qa,selfName=aaaa,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=27357,hostnameExternal=219.241.144.88,portExternalIpv4=27357,sigPublicKey=<null>,agreePublicKey=<null>,sigCert=com.swirlds.platform.crypto.SerializableX509Certificate@74b39466,agreeCert=com.swirlds.platform.crypto.SerializableX509Certificate@2bbbc4fd,memo=Ht0Z8kdk],
   Address[id=1,nickname=9wNXAj2V,selfName=aaab,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=4552,hostnameExternal=…, {0=KeysAndCerts[sigKeyPair=java.security.KeyPair@2b47778c, agrKeyPair=java.security.KeyPair@6cdb9133, sigCert=[
[
  Version: V3
  Subject: CN=s-aaaa
  Signature Algorithm: SHA384withRSA, OID = 1.2.840.113549.1.1.12

  Key:  Sun RSA public key, 3072 bits
  params: null
  modulus: 399359783971008386823194517591913909076180800663617430152293322362851354916562240539217992749052543798926670565779538052222399243364172487884744393106571360720093667481704909500324706084082081682560810453972293976421988390921489916…
com.swirlds.platform.crypto.KeysAndCertsTest ‑ [2] AddressBook {
   Address[id=0,nickname=efY74fua,selfName=aaaa,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=29632,hostnameExternal=164.37.214.144,portExternalIpv4=29632,sigPublicKey=<null>,agreePublicKey=<null>,sigCert=com.swirlds.platform.crypto.SerializableX509Certificate@704666bf,agreeCert=com.swirlds.platform.crypto.SerializableX509Certificate@123561f2,memo=Cjj4xgbL],
   Address[id=3,nickname=ygnjNUyN,selfName=aaab,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=21566,hostnameExternal…, {0=KeysAndCerts[sigKeyPair=java.security.KeyPair@2edd2bde, agrKeyPair=java.security.KeyPair@6ac7f481, sigCert=  [0]         Version: 3
         SerialNumber: 12482092706667292405
             IssuerDN: CN=s-aaaa
           Start Date: Sat Jan 01 00:00:00 UTC 2000
           Final Date: Fri Jan 01 00:00:00 UTC 2100
            SubjectDN: CN=s-aaaa
           Public Key: RSA Public Key [2e:28:bc:1e:d3:83:25:92:8e:cb:98:b1:b6:84:06:9c:d5:d8:14:d5],[56:66:d1:a4]
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5…
…

Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.39%. Comparing base (ce6f299) to head (4ed37b5).

Additional details and impacted files
@@              Coverage Diff              @@
##             develop   #13365      +/-   ##
=============================================
- Coverage      67.39%   67.39%   -0.01%     
- Complexity     36216    36217       +1     
=============================================
  Files           3701     3701              
  Lines         148961   148961              
  Branches       15500    15500              
=============================================
- Hits          100391   100387       -4     
- Misses         44220    44222       +2     
- Partials        4350     4352       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Node: HAPI Test (Time Consuming) Results

21 tests   21 ✅  54m 36s ⏱️
 3 suites   0 💤
 3 files     0 ❌

Results for commit 4ed37b5.

Copy link
Member

@kimbor kimbor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link

Node: HAPI Test (Smart Contract) Results

604 tests   604 ✅  1h 12m 30s ⏱️
 63 suites    0 💤
 63 files      0 ❌

Results for commit 4ed37b5.

@povolev15 povolev15 merged commit 746568e into develop May 20, 2024
44 of 47 checks passed
@povolev15 povolev15 deleted the 13293-InitialModServiceAdminSchema-code-coverage branch May 20, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InitialModServiceAdminSchema[77 %]
2 participants