Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert recycle-bin store location (#13339) #13366

Merged
merged 2 commits into from
May 20, 2024

Conversation

mxtartaglia-sl
Copy link
Contributor

Description:

Tries to Cherry-pick, from develop:aa96fc9

Signed-off-by: mxtartaglia <maxi@swirldslabs.com>
Copy link
Member

@Neeharika-Sompalli Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from hedera-base

cody-littley
cody-littley previously approved these changes May 16, 2024
Signed-off-by: Kim Rader <kim.rader@swirldslabs.com>
Copy link

Node: HAPI Test (Node Death Reconnect) Results

2 tests   2 ✅  7m 12s ⏱️
2 suites  0 💤
2 files    0 ❌

Results for commit d875c3b.

Copy link

Node: HAPI Test (Restart) Results

2 tests   2 ✅  5m 32s ⏱️
2 suites  0 💤
2 files    0 ❌

Results for commit d875c3b.

Copy link

Node: HAPI Test (Token) Results

235 tests   234 ✅  22m 15s ⏱️
 17 suites    1 💤
 17 files      0 ❌

Results for commit d875c3b.

Copy link

Node: HAPI Test (Crypto) Results

335 tests   335 ✅  39m 13s ⏱️
 25 suites    0 💤
 25 files      0 ❌

Results for commit d875c3b.

Copy link

Node: HAPI Test (Misc) Results

459 tests   449 ✅  42m 5s ⏱️
 77 suites   10 💤
 77 files      0 ❌

Results for commit d875c3b.

Copy link

Node: HAPI Test (Time Consuming) Results

21 tests   21 ✅  54m 5s ⏱️
 3 suites   0 💤
 3 files     0 ❌

Results for commit d875c3b.

Copy link

Node: Unit Test Results

  2 267 files  ±0    2 267 suites  ±0   2h 27m 52s ⏱️ - 15m 14s
112 339 tests ±0  112 272 ✅ ±0  67 💤 ±0  0 ❌ ±0 
120 802 runs  ±0  120 735 ✅ ±0  67 💤 ±0  0 ❌ ±0 

Results for commit d875c3b. ± Comparison against base commit fd04c15.

Copy link

Node: HAPI Test (Smart Contract) Results

588 tests   588 ✅  1h 15m 14s ⏱️
 63 suites    0 💤
 63 files      0 ❌

Results for commit d875c3b.

Copy link
Member

@kimbor kimbor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@poulok poulok added this to the v0.50 milestone May 20, 2024
@poulok poulok merged commit 970cb59 into release/0.50 May 20, 2024
43 of 44 checks passed
@poulok poulok deleted the 13334_cherry_pick_reworked branch May 20, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants