Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix module-info.java #4406

Merged
merged 1 commit into from Dec 2, 2022
Merged

Fix module-info.java #4406

merged 1 commit into from Dec 2, 2022

Conversation

Neeharika-Sompalli
Copy link
Member

Signed-off-by: Neeharika-Sompalli neeharika.sompalli@swirldslabs.com

Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
@@ -34,8 +34,6 @@
requires grpc.stub;
requires commons.collections4;

exports com.hedera.node.app.service.mono to
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's remove the "to ...." since PR #4395 needs it for an additional module ;)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean just add exports com.hedera.node.app.service.mono ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is already defined on line 2 :)

@Neeharika-Sompalli Neeharika-Sompalli merged commit d1ca7b3 into develop Dec 2, 2022
@Neeharika-Sompalli Neeharika-Sompalli deleted the fix-develop branch December 2, 2022 14:27
@sonarcloud
Copy link

sonarcloud bot commented Dec 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants