Update Artifact Actions to use > v4.0.0 #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
We will need to update https://github.com/hashicorp/actions-docker-build/blob/main/.github/workflows/test.yml#L255 for the tests too :) |
ashconnor
changed the title
ashconnor
force-pushed
the
ashley/update-artifact-actions
branch
from
6a32ec4
to
f818ae0
Compare
|
Parallel tl;dr: |
- The current major version (v3) of the artifact actions uses a deprecated version of NodeJS v16. This commit updates the artifact actions to use v4 which includes a supported version of NodeJS v20. - Update test action references - Set overwrite to true to mimic previous behavior - Update example workflow
ashconnor
force-pushed
the
ashley/update-artifact-actions
branch
from
f818ae0
to
196f312
Compare
|
Is it possible to get this PR merged and released soon? We don't have long until node16 support is dropped (may 13) |
…e and may not actually matter. ideal-enigma doesn't care - need to check with v0 code too) remove debug statements
alvin-huang
reviewed
May 8, 2024
sarahethompson
force-pushed
the
ashley/update-artifact-actions
branch
from
164aff3
to
3802549
Compare
sarahethompson
requested review from
alvin-huang,
a team,
aaron-lane and
shore
and removed request for
a team and
aaron-lane
alvin-huang
reviewed
May 8, 2024
alvin-huang
reviewed
May 8, 2024
action.yml
Outdated
| env: | ||
| # Add _redhat if this is a redhat call. | ||
| REDHAT_SUFFIX: ${{ inputs.redhat_tag && '_redhat' || '' }} | ||
| RANDOM: "${{ env.RANDOM_STRING }}" |
There was a problem hiding this comment.
Do we need this if we don't use it?
alvin-huang
reviewed
May 8, 2024
.github/workflows/example.yml
Outdated
| with: | ||
| path: example/${{ env.product_name }}_${{ env.product_version }}_${{ matrix.goos }}_${{ matrix.goarch }}.zip | ||
| name: ${{ env.product_name }}_${{ env.product_version }}_${{ matrix.goos }}_${{ matrix.goarch }}.zip | ||
| if-no-files-found: error | ||
| overwrite: true |
There was a problem hiding this comment.
Do we still need the overwrite here?
alvin-huang
approved these changes
May 8, 2024
|
Wohoo! Thankyou |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Justification
update actions/download-artifact used by hashicorp/actions-docker-build
Summary
Quality
All changes to behavior should be accompanied by relevant tests which both document and protect it.
This PR includes: