Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contrib: add first draft of Connect CA developer docs #10578

Merged
merged 8 commits into from
Jan 26, 2022
Merged

contrib: add first draft of Connect CA developer docs #10578

merged 8 commits into from
Jan 26, 2022

Conversation

dnephin
Copy link
Contributor

@dnephin dnephin commented Jul 8, 2021 •
edited

@dnephin dnephin added the pr/no-changelog PR does not need a corresponding .changelog entry label Jul 8, 2021
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging July 8, 2021 20:07 Inactive
@vercel vercel bot temporarily deployed to Preview – consul July 8, 2021 20:07 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging July 8, 2021 21:13 Inactive
@vercel vercel bot temporarily deployed to Preview – consul July 8, 2021 21:13 Inactive
@vercel vercel bot temporarily deployed to Preview – consul July 8, 2021 21:14 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging July 8, 2021 21:14 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging July 9, 2021 14:28 Inactive
@vercel vercel bot temporarily deployed to Preview – consul July 9, 2021 14:28 Inactive
@vercel vercel bot temporarily deployed to Preview – consul July 9, 2021 19:24 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging July 9, 2021 19:24 Inactive
@vercel vercel bot temporarily deployed to Preview – consul July 16, 2021 20:48 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging July 16, 2021 20:48 Inactive
@dnephin dnephin marked this pull request as ready for review January 10, 2022 18:32
@dnephin dnephin changed the title WIP: contrib: add first draft of Connect CA developer docs contrib: add first draft of Connect CA developer docs Jan 10, 2022
@vercel vercel bot temporarily deployed to Preview – consul January 26, 2022 17:13 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging January 26, 2022 17:13 Inactive
@vercel vercel bot temporarily deployed to Preview – consul January 26, 2022 17:18 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging January 26, 2022 17:20 Inactive
dhiaayachi
dhiaayachi approved these changes Jan 26, 2022
View reviewed changes
Copy link
Collaborator

@dhiaayachi dhiaayachi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will probably need to revise this doc as we go, but let's get it merged and improve it as we go.

LGTM!

contributing/service-mesh/ca/README.md Outdated
of trust.

In the primary datacenter, the Consul and AWS providers use the Primary Root CA to sign
leaf certificates. The Vault provider uses an intermediate CA to sign leaf certificates.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this currently true? I thought you are working on making this possible @dnephin

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya, this is currently true.

The work I'm doing in #11910 is to use an intermediate as the Primary CA, and an external root.

@dnephin dnephin merged commit 295ef2e into main Jan 26, 2022
@dnephin dnephin deleted the pairing/contrib-ca-docs branch January 26, 2022 17:39
@hc-github-team-consul-core
Copy link
Collaborator

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/566566.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhiaayachi dhiaayachi dhiaayachi approved these changes

Assignees
No one assigned
Labels
pr/no-changelog PR does not need a corresponding .changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dnephin @hc-github-team-consul-core @dhiaayachi