Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ca: add support for an external trusted CA #11910

Merged
merged 9 commits into from
Feb 22, 2022
Merged

ca: add support for an external trusted CA #11910

merged 9 commits into from
Feb 22, 2022

Commits on Feb 17, 2022

  1. ca: only return the leaf cert from Sign in vault provider 

    The interface is documented as 'Sign will only return the leaf', and the other providers
only return the leaf. It seems like this was added during the initial implementation, so
is likely just something we missed. It doesn't break anything , but it does cause confusing cert chains
in the API response which could break something in the future.
    @dnephin
    dnephin committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    c1c1580 View commit details
    Browse the repository at this point in the history

  2. ca: cleanup validateSetIntermediate

    @dnephin
    dnephin committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    8699481 View commit details
    Browse the repository at this point in the history

  3. ca: small docs improvements

    @dnephin
    dnephin committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    71f3ae0 View commit details
    Browse the repository at this point in the history

  4. ca: examine the full chain in newCARoot 

    make TestNewCARoot much more strict
compare the full result instead of only a few fields.
add a test case with 2 and 3 certificates in the pem
    @dnephin
    dnephin committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    42ec34d View commit details
    Browse the repository at this point in the history

  5. ca: add a test for secondary with external CA

    @dnephin
    dnephin committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    5e8ea2a View commit details
    Browse the repository at this point in the history

  6. ca: add test cases for rotating external trusted CA

    @dnephin
    dnephin committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    1853a32 View commit details
    Browse the repository at this point in the history

  7. docs: add docs for using an external CA

    @dnephin
    dnephin committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    12f12d5 View commit details
    Browse the repository at this point in the history

  8. Update TODOs to reference an issue with more details 

    And remove a no longer needed TODO
    @dnephin
    dnephin committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    6b679aa View commit details
    Browse the repository at this point in the history

  9. ca: test that original certs from secondary still verify 

    There's a chance this could flake if the secondary hasn't received the
update yet, but running this test many times doesn't show any flakes
yet.
    @dnephin
    dnephin committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    6021105 View commit details
    Browse the repository at this point in the history