-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Ability to watch for events in all data centers #20908
base: main
Are you sure you want to change the base?
feat: Ability to watch for events in all data centers #20908
Conversation
Hi @david-yu / @jkirschner-hashicorp / @huikang, FYI @jakubgs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR, looks mostly good, but it seems to me like both RunWithClientAndHclogAllDatacenters
and RunWithClientAndHclog
are very similar. One could say that one is just a special case of the other. It would probably make more sense to do this with one function that always loops over DCs, and one DC watching is simply a special case of that where the list has just one element.
Hi @david-yu / @jkirschner-hashicorp / @huikang , |
Description
fixes #20871
Testing & Reproduction steps
Links
PR Checklist