Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] adds revalidate tutorial endpoint #1680

Closed

Conversation

kendallstrautman
Copy link
Contributor

πŸ”— Relevant links

πŸ—’οΈ What

🀷 Why

πŸ› οΈ How

πŸ“Έ Design Screenshots

πŸ§ͺ Testing

πŸ’­ Anything else?

@vercel
Copy link

vercel bot commented Feb 24, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
dev-portal βœ… Ready (Inspect) Visit Preview Feb 24, 2023 at 5:23AM (UTC)

@kendallstrautman kendallstrautman changed the base branch from main to ks.add-isr-tutorial-paths February 24, 2023 05:23
@github-actions
Copy link

Some suggested prefixes and emojis that may help to write clear, actionable code review comments:

Praise πŸ™Œ Question πŸ™‹ Thought πŸ’­ Blocker 🚧 Future πŸ“Œ Optional 🎨 Nitpick ⛏️
Expand for comment prefix descriptions
Prefix+Emoji Description
Praise πŸ™Œ Use to highlight something positive. It's nice to try to leave one per review, but don't leave false praise just to leave one of these comments.
Question πŸ™‹ Use to gain clarity from the code author. The conversation could evolve into any one of these other categories. Only the reviewer should resolve these comment threads.
Thought πŸ’­ Use to share context, leave a breadcrumb, or share an idea that came up while reviewing.
Blocker 🚧 Use to request changes that block merging the current PR. Only the reviewer should resolve these comment threads.
Future πŸ“Œ Use to request changes that the code author can choose to address in the current PR or a follow-up one.
Optional 🎨 Use to suggest optional changes that you feel strongly about but ultimately defer to the code author to make a decision on. These can be comments that turn into valuable conversation starters for adopting new code styles, guidelines, or team practices.
Nitpick ⛏️ Use to suggest changes based on loose opinions or personal preferences. The difference between this and Optional 🎨  is how strong the code reviewer's opinion is.

Comment on lines +68 to +75
* TODO consider busting the cache for all other tutorials in the collections as well
* this would only matter in the case of a name change for the sidebar data.
*
* This would require an additional API call as we don't have the tutorial
* array within the featured collection objects with this return data.
*
* See the `augmentTutorial` function in src/lib/learn-client/api/tutorial/augment-tutorial.ts
* for an example of getting full tutorial data from featured collections.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm leaning towards going the 'nuclear' route instead where whenever a pr is merged to main in tutorials repo, we bust the entire cache for all tutorials sub-routes. This current setup with the learn api means that every time a single tutorial is updated in the database, this endpoint will be hit.

This finite approach is nice in theory but I see a need to build the workflow when we bust the entire cache anyways since this won't get everything. Perhaps until we get this feature, we could hold off here.

@github-actions
Copy link

github-actions bot commented Feb 24, 2023

πŸ“¦ Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action πŸ€–

This PR introduced no changes to the javascript bundle πŸ™Œ

@github-actions
Copy link

This PR is stale because it has been open 20 days with no activity. It will be closed in 5 days unless you remove the stale label or comment.

@github-actions github-actions bot added the stale label Mar 16, 2023
@github-actions
Copy link

This PR was closed because it has been marked stale for 5 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants