-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wip] adds revalidate tutorial endpoint #1680
[wip] adds revalidate tutorial endpoint #1680
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
Some suggested prefixes and emojis that may help to write clear, actionable code review comments:
Expand for comment prefix descriptions
|
* TODO consider busting the cache for all other tutorials in the collections as well | ||
* this would only matter in the case of a name change for the sidebar data. | ||
* | ||
* This would require an additional API call as we don't have the tutorial | ||
* array within the featured collection objects with this return data. | ||
* | ||
* See the `augmentTutorial` function in src/lib/learn-client/api/tutorial/augment-tutorial.ts | ||
* for an example of getting full tutorial data from featured collections. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm leaning towards going the 'nuclear' route instead where whenever a pr is merged to main in tutorials repo, we bust the entire cache for all tutorials sub-routes. This current setup with the learn api means that every time a single tutorial is updated in the database, this endpoint will be hit.
This finite approach is nice in theory but I see a need to build the workflow when we bust the entire cache anyways since this won't get everything. Perhaps until we get this feature, we could hold off here.
π¦ Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action π€ This PR introduced no changes to the javascript bundle π |
This PR is stale because it has been open 20 days with no activity. It will be closed in 5 days unless you remove the |
This PR was closed because it has been marked stale for 5 days with no activity. |
π Relevant links
ποΈ What
π€· Why
π οΈ How
πΈ Design Screenshots
π§ͺ Testing
π Anything else?