feat: adds revalidate all tutorials endpoint #1684
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Some suggested prefixes and emojis that may help to write clear, actionable code review comments:
Expand for comment prefix descriptions
|
📦 Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action 🤖 This PR introduced no changes to the javascript bundle 🙌 |
| rawProductSlug === 'well-architected-framework' || | ||
| rawProductSlug === 'onboarding' | ||
| ) { | ||
| if (rawProductSlug in SectionOption) { |
There was a problem hiding this comment.
Random cleanup here
| // Loop over all paths to revalidate in batches | ||
| // as this endpoint will fire off >1000 revalidation requests | ||
| let batchRevalidatePromises = [] | ||
| for (let i = 0; i < paths.length; i++) { |
There was a problem hiding this comment.
Referenced the batching implementation in the learn api content sync here.
kendallstrautman
changed the title
| async function getCollectionAndTutorialPaths() { | ||
| const collectionPaths = [] | ||
| const tutorialPaths = [] | ||
| const allCollections = await getAllCollections() | ||
|
|
||
| allCollections.forEach((collection: ClientCollection) => { | ||
| // build collection paths | ||
| collectionPaths.push(getCollectionSlug(collection.slug)) | ||
|
|
||
| // build tutorial paths | ||
| collection.tutorials.forEach((tutorial: ClientTutorialLite) => { | ||
| tutorialPaths.push(getTutorialSlug(tutorial.slug, collection.slug)) | ||
| }) | ||
| }) | ||
|
|
||
| return [...collectionPaths, ...tutorialPaths] | ||
| } |
There was a problem hiding this comment.
Nice, I like that the act of getting all of these paths is fairly straightforward.
|
@BRKalow just removed the delay implementation and left a note for the future on throttling. Lmk if you see any other things to improve |
Let's give it a shot!
| const allCollections = await getAllCollections() | ||
|
|
||
| allCollections.forEach((collection: ClientCollection) => { | ||
| // build collection paths | ||
| collectionPaths.push(getCollectionSlug(collection.slug)) |
There was a problem hiding this comment.
@nayres this is some code to reference for generating the collection paths!
Co-authored-by: Bryce Kalow <bkalow@hashicorp.com>
kendallstrautman
force-pushed
the
ks.adds-revalidate-all-tutorials
branch
from
5e5b43d
to
8aa825b
Compare
|
Testing the full flow from a tutorials action trigger here https://github.com/hashicorp/tutorials/actions/runs/4325350508/jobs/7551391150 |
|
This PR is stale because it has been open 20 days with no activity. It will be closed in 5 days unless you remove the |
🔗 Relevant links
🗒️ What
Adds a new api endpoint to handle revalidating all tutorials landing, collection and individual tutorial paths. This endpoint will be called after the production content sync is done to bust the cache for all tutorials routes - see related PR
After this PR is merged, I will test the revalidation endpoint before merging the update to the tutorials prod sync workflow.
🤷 Why
🛠️ How
📸 Design Screenshots
🧪 Testing
💭 Anything else?