-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add e2e test for tutorials content correctness #2055
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📦 Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action 🤖 This PR introduced no changes to the javascript bundle 🙌 |
['/hcp/tutorials/networking', 'HashiCorp Virtual Network'], | ||
['/vault/tutorials/operations/configure-vault', 'Configure Vault'], | ||
['/consul/tutorials/get-started-hcp/hcp-gs-deploy', 'Deploy HCP Consul'], | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: add more path+h1 pairs here.
I think having a hard-coded list here should be reasonable for the near future.
- having no abstraction here should make it easy to delete, modify, and add cases
Depending on test slowness, I think 100+ tutorials should be a reasonably wide net that'll give us confidence during the next Next.js upgrade.
TODO: also add docs routes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💭 Definitely fine for now while we troubleshoot but if we want this test to always run in the future, it should be driven off real api data (staging for tutorials) in case headings / filenames for tutorials change.
9140841
to
71dc2c4
Compare
1e81052
to
84ae45d
Compare
Description
This adds e2e tests to ensure tutorials content correctness.
Why? — During next.js upgrades fro m
13.0.5
to13.4.x
, incorrect tutorials have been rendered at certain paths. This test aims to catch those cases.