Ignore comments in checksum files #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
set noninteractive mode to installation
pin to go 1.15, because it worked//works there; I suspect this is a "debian changed something" issue.
nywilken
approved these changes
Jan 31, 2022
There was a problem hiding this comment.
This looks good to me. I was curious on what would happen if the test file looked like the example in the packer issue. More specifically containing lines that are not checksums or comments but it looks like parseChecksumLine would return an error and the caller would continue. So this looks good.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
sylviamoss
approved these changes
Jan 31, 2022
| case '#', '/', '-': | ||
| return nil, nil // skip | ||
| } | ||
| //TODO: this function will fail if we pass a checksum for a path with spaces |
There was a problem hiding this comment.
I'm not sure if I understood this one 👀
There was a problem hiding this comment.
strings.Fields splits on spacing characters, so if a file being checksummed is "my file.iso" or "my\ file.iso", then the count of the switch will be all messed up
|
Thx ! |
This was referenced Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a tiny simple step towards #217 and hashicorp/packer#10423