Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Append tar and ova decompressor in v2 #351

Merged
merged 1 commit into from Jan 31, 2022
Merged

Append tar and ova decompressor in v2 #351

merged 1 commit into from Jan 31, 2022

Conversation

LeConTesteur
Copy link

Hello,

I try to implement this issue hashicorp/packer-plugin-qemu#7.
The plugin use go-getter v2 for decompress archive, however tar or ova are unsupported in this version.

So I append tar support. I cherry-pick the commit 6a2a051 and append two new entries in the decompressor map.

azr
azr approved these changes Jan 31, 2022
View reviewed changes
Copy link
Contributor

@azr azr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch, merci ! 🙂

@azr azr merged commit ea452ad into hashicorp:v2 Jan 31, 2022
@LeConTesteur LeConTesteur deleted the dev/append_tar_decompressor branch January 31, 2022 12:01
@azr azr added the enhancement label Feb 9, 2022
@nywilken nywilken mentioned this pull request Mar 16, 2022
Merged
@nywilken nywilken mentioned this pull request Jun 6, 2022
Merged
@nywilken nywilken mentioned this pull request Nov 30, 2022
Merged
This was referenced Mar 16, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azr azr azr approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LeConTesteur @azr @schmichael