Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2: upgrade AWS SDK version #385

Merged
merged 2 commits into from Oct 26, 2022
Merged

v2: upgrade AWS SDK version #385

merged 2 commits into from Oct 26, 2022

Conversation

kmoe
Copy link
Member

@kmoe kmoe commented Oct 12, 2022

Closes #383

@jukie
Copy link
Contributor

jukie commented Oct 20, 2022

@kmoe doesn't look like these tests are succeeding against the current v2 branch either. Is anyone working on fixing these or does someone need to take on updating the client config and/or tests?

@nywilken
Copy link
Member

@kmoe thanks for open up this PR, and @jukie thanks bubbling up the failures. We are working on getting the tests passing in a separate branch. Once that is working we can rebase and validate that things are working as expected.

@nywilken nywilken self-assigned this Oct 21, 2022
@nywilken nywilken self-requested a review October 21, 2022 15:55
This was referenced Oct 26, 2022
@nywilken nywilken merged commit cb3ab9c into v2 Oct 26, 2022
@nywilken nywilken deleted the update-aws-lib-version branch October 26, 2022 21:03
@jukie
Copy link
Contributor

jukie commented Oct 27, 2022

Thanks @nywilken! We've already added a workaround internally so no rush but could you offer a rough eta or expectations for cutting a release and getting that pulled upstream to Terraform?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants