Improve performance of FromObject and parseUUID #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
banks
approved these changes
Jun 7, 2023
There was a problem hiding this comment.
Awesome. LGTM.
I checked the UUID index tests which do an OK job of testing different cases we expect to parse or not and this passes so seems like a solid improvement!
Is it worth adding a case to the existing test that exercises the invalid Hex path? It doesn't seem to have any input that would make it through hexToByte with an invalid input?
Neal
reviewed
Jun 15, 2023
| arg += "\x00" | ||
| return []byte(arg), nil | ||
|
|
||
| // Convert to a []byte with a trailing nul byte |
There was a problem hiding this comment.
typo:
Suggested change
| // Convert to a []byte with a trailing nul byte | |
| // Convert to a []byte with a trailing null byte |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FromObject had a bug where it was attempting to preallocate a slice with
enough capacity to avoid growth, by calculating length^3. But ^ is XOR, so
it was allocation an empty slice (or at least much smaller than expected).
parseUUID is a bit of a odd function, parsing partial UUIDs as well as
correct ones. Simplified it to improve perf by 60%.