-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more helpful message on plugin setup failure #223
Merged
Merged
Commits on Dec 2, 2022
-
Add more helpful message on plugin setup failure
The current error message shown when a plugin does not respond correctly can be obtuse to the end user of, for example, Vault. Here, we add potential reasons why the plugin did not respond correctly, and some additional debugging information (provided as a best effort) including the CPU architecture that the plugin was compiled for, the current CPU architecture, and the permissions of the plugin. Hopefully this will help users diagnose why their plugin is not loading. We also added a `testdata/` directory that is optionally populated with executables in various formats to help test the additional debugging information. The binaries are over 1 MB each though, so are not checked in, and the test will be skipped if they have not been compiled.
Christopher Swenson committedDec 2, 2022 Configuration menu - View commit details
-
Copy full SHA for 2eb67ee - Browse repository at this point
Copy the full SHA 2eb67eeView commit details -
Christopher Swenson committed
Dec 2, 2022 Configuration menu - View commit details
-
Copy full SHA for b68c43a - Browse repository at this point
Copy the full SHA b68c43aView commit details -
Co-authored-by: Calvin Leung Huang <1883212+calvn@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for e3c0d2e - Browse repository at this point
Copy the full SHA e3c0d2eView commit details -
Christopher Swenson committed
Dec 2, 2022 Configuration menu - View commit details
-
Copy full SHA for 450593f - Browse repository at this point
Copy the full SHA 450593fView commit details
Commits on Dec 5, 2022
-
Co-authored-by: Tom Proctor <tomhjp@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for cfea36e - Browse repository at this point
Copy the full SHA cfea36eView commit details -
Co-authored-by: Tom Proctor <tomhjp@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 996b4d6 - Browse repository at this point
Copy the full SHA 996b4d6View commit details -
Co-authored-by: Tom Proctor <tomhjp@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for b47fd64 - Browse repository at this point
Copy the full SHA b47fd64View commit details -
Add additional notes about users and groups
Christopher Swenson committedDec 5, 2022 Configuration menu - View commit details
-
Copy full SHA for b616f4e - Browse repository at this point
Copy the full SHA b616f4eView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.