Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more helpful message on plugin setup failure #223

Merged
merged 8 commits into from Dec 5, 2022

Commits on Dec 2, 2022

  1. Add more helpful message on plugin setup failure

    The current error message shown when a plugin does not respond correctly
    can be obtuse to the end user of, for example, Vault.
    
    Here, we add potential reasons why the plugin did not respond correctly,
    and some additional debugging information (provided as a best effort)
    including the CPU architecture that the plugin was compiled for,
    the current CPU architecture, and the permissions of the plugin.
    Hopefully this will help users diagnose why their plugin is not loading.
    
    We also added a `testdata/` directory that is optionally populated
    with executables in various formats to help test the additional
    debugging information. The binaries are over 1 MB each though, so
    are not checked in, and the test will be skipped if they have not been
    compiled.
    Christopher Swenson committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    2eb67ee View commit details
    Browse the repository at this point in the history
  2. Don't use named return value

    Christopher Swenson committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    b68c43a View commit details
    Browse the repository at this point in the history
  3. Update client.go

    Co-authored-by: Calvin Leung Huang <1883212+calvn@users.noreply.github.com>
    swenson and calvn committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    e3c0d2e View commit details
    Browse the repository at this point in the history
  4. Unimportant typo fix

    Christopher Swenson committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    450593f View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2022

  1. Update client.go

    Co-authored-by: Tom Proctor <tomhjp@users.noreply.github.com>
    swenson and tomhjp committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    cfea36e View commit details
    Browse the repository at this point in the history
  2. Update testdata/README.md

    Co-authored-by: Tom Proctor <tomhjp@users.noreply.github.com>
    swenson and tomhjp committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    996b4d6 View commit details
    Browse the repository at this point in the history
  3. Update client.go

    Co-authored-by: Tom Proctor <tomhjp@users.noreply.github.com>
    swenson and tomhjp committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    b47fd64 View commit details
    Browse the repository at this point in the history
  4. Add additional notes about users and groups

    Christopher Swenson committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    b616f4e View commit details
    Browse the repository at this point in the history