Add support for RFC1123 Date/Time in Retry-After header. #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
palczyn
force-pushed
the
retry-after-timestamp
branch
from
2757bfb
to
2c21d87
Compare
palczyn
force-pushed
the
retry-after-timestamp
branch
from
2c21d87
to
8ebfaae
Compare
|
Here is another pull request that accomplishes the same. PR #138 |
|
Also this PR is heavily inspired by PR #130 as it was the one I saw first and I decided to resolve conflicts that arose in the meantime. |
|
I opened #144 for discussion about the feature. Given that there are now 3 PRs that accomplish the same thing, we should probably consolidate discussion in a single place. |
|
@PalczynskiMaciej Thanks for submitting this PR. I appreciate that this PR, and #130 which it seems to be based on, have been outstanding for a long time, however I'm going to merge #138 for this functionality as that has additional safety checks on the resulting duration after parsing. Thanks again for working on this. |
|
Duplicate of #138 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Retry-After response HTTP header indicates how long the user agent should wait before making a follow-up request. It can be declared with a time duration or timestamp but go-retryablehttp supports only time duration.
Directives
<http-date>
A date after which to retry. See the Date header for more details on the HTTP date format.
<delay-seconds>
A non-negative decimal integer indicating the seconds to delay after the response is received.