Ensure license files are tracked during installation so they can be removed #206
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #197
The implementation has a few (intentional) side effects which may be worth calling out here:
EULA.txt
or CE related files likeLICENSE.txt
. It keeps the implementation simple and I don't see harm in it.LICENSE.txt
but more often justLICENSE
. The assumption I'm making there is that over time, those files would be renamed toLICENSE.txt
and no renaming would happen as part of a release. Again though - it's just best-effort basis that seemed relatively low effort.Out of scope
As the diff was growing larger I decided to keep the additional
LicenseDir
option out of scope for this PR but I'd be happy to address that in a separate PR. We agreed on the default behaviour anyway, so the future PR won't change that as it will be "opt in".