Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump github.com/containernetworking/plugins from 1.2.0 to 1.4.1 #20146

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 17, 2024

Bumps github.com/containernetworking/plugins from 1.2.0 to 1.4.1.

Release notes

Sourced from github.com/containernetworking/plugins's releases.

v1.4.1

No release notes provided.

CNI Plugins v1.4.0

New features:

  • (#832). tap: allow for a tap device to be created as a bridge port
  • (#914). [tuning] add ability to set tx queue len

Improvements:

  • (#969). Add CNI_NETNS_OVERRIDE
  • (#979). Add ndisc_notify in ipvlan for ipv6 ndp
  • (#974). macvlan: enable ipv6 ndisc_notify
  • (#950). Create IPAM files with 0600 permissions
  • (#924). More efficient iptables usage.
  • (#902). spoofcheck: Make use of go-nft's ApplyConfigEcho(). This is much faster
  • (#874). Add routes propagation for VRF plugin

Build:

  • (#982). Bump to golang:1.21-alpine
  • (#948). build: Use POSIX sh for shell scripts

Bug fixes:

  • (#954). macvlan cmdDel: handle deletion when master has been deleted
  • (#927). vrf: fix route filter to use output iface

CNI Plugins v1.3.0

This release introduces a new plugin: tap. Thanks to @​mmirecki for contributing this

New features:

  • (#784). tap: This PR adds a plugin to create tap devices.
  • (#829). bridge: add vlan trunk support
  • (#875). bridge: Add parameter to disable default vlan
  • (#814). macvlan: Add support for in-container master
  • (#813). ipvlan: Add support for in-container master
  • (#781). vlan: Add support for in-container master

Improvements:

  • (#880). bridge: read only required chain on cni del instead of the entire ruleset
  • (#873). bridge, spoof check: remove drop rule index

Bug fixes:

  • (#892). sbr: Ignore LinkNotFoundError during cmdDel null
  • (#887). ptp: Fix ValidateExpectedRoute with non default routes and nil GW
  • (#885). tuning: fix cmdCheck when using IFNAME
  • (#831). Fix overwritten error var in getMTUByName
  • (#821). Only check or del ipv6 when an IPv6 is configured
Commits
  • 8fc26ce Merge pull request #991 from containernetworking/dependabot/docker/dot-github...
  • c8d165d Merge branch 'main' into dependabot/docker/dot-github/actions/retest-action/a...
  • 1b58119 Merge pull request #1010 from containernetworking/dependabot/github_actions/a...
  • 8a3014f build(deps): bump actions/checkout from 3 to 4
  • 019727a Merge pull request #1005 from austinvazquez/update-golangci-lint-action-package
  • 352e051 Update golangci-lint-action package to v4
  • 9c016b5 Rename unused variables to resolve lint warnings
  • 0729398 Merge pull request #1017 from containernetworking/dependabot/go_modules/golan...
  • 394ab0d build(deps): bump the golang group with 5 updates
  • 0144de0 Merge pull request #1011 from containernetworking/dependabot/github_actions/a...
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@tgross
Copy link
Member

tgross commented Apr 18, 2024

@dependabot rebase

Bumps [github.com/containernetworking/plugins](https://github.com/containernetworking/plugins) from 1.2.0 to 1.4.1.
- [Release notes](https://github.com/containernetworking/plugins/releases)
- [Commits](containernetworking/plugins@v1.2.0...v1.4.1)

---
updated-dependencies:
- dependency-name: github.com/containernetworking/plugins
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@tgross
Copy link
Member

tgross commented Apr 18, 2024

It doesn't look like there are any libcni changes here, so I'm going to backport this even though we don't especially need it just so that backport branches are up-to-date.

@tgross tgross added backport/1.5.x backport to 1.5.x release line backport/1.6.x backport to 1.6.x release line backport/1.7.x backport to 1.7.x release line labels Apr 18, 2024
@tgross
Copy link
Member

tgross commented Apr 18, 2024

Well apparently after rebasing this is causing some driver tests to fail. I can reproduce the test failure locally but not on main. Will investigate, but it's not a critical update.

@tgross
Copy link
Member

tgross commented Apr 18, 2024

So this is causing a bunch of errors in docker driver tests because it updates a ton of transient dependencies, and it's bringing in a pile of new transient dependencies like opentelemetry (!?). But it turns out that literally the only thing we bring it in for is a single file pkg/ns/ns_linux.go, which we use in a couple places for running a goroutine in specific network namespace, and which hasn't needed an update in a couple of years. A good chunk of the file was partially vendored into client/lib/nsutil already.

I'm going to refactor client/lib/nsutil to fully vendor pkg/ns/ns_linux.go, and that'll let us drop this dependency entirely.

@tgross tgross self-assigned this Apr 18, 2024
@tgross tgross removed backport/1.5.x backport to 1.5.x release line backport/1.6.x backport to 1.6.x release line backport/1.7.x backport to 1.7.x release line labels Apr 18, 2024
tgross added a commit that referenced this pull request May 10, 2024
We bring in `containernetworking/plugins` for the contents of a single file,
which we use in a few places for running a goroutine in a specific network
namespace. This code hasn't needed an update in a couple of years, and a good
chunk of what we need was previously vendored into `client/lib/nsutil`
already.

Updating the library via dependabot is causing errors in Docker driver tests
because it updates a lot of transient dependencies, and it's bringing in a pile
of new transient dependencies like opentelemetry. Avoid this problem going
forward by vendoring the remaining code we hadn't already.

Ref: #20146
@tgross
Copy link
Member

tgross commented May 10, 2024

Closing in lieu of #20556

@tgross tgross closed this May 10, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github May 10, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/go_modules/github.com/containernetworking/plugins-1.4.1 branch May 10, 2024 19:52
tgross added a commit that referenced this pull request May 13, 2024
…20556)

We bring in `containernetworking/plugins` for the contents of a single file,
which we use in a few places for running a goroutine in a specific network
namespace. This code hasn't needed an update in a couple of years, and a good
chunk of what we need was previously vendored into `client/lib/nsutil`
already.

Updating the library via dependabot is causing errors in Docker driver tests
because it updates a lot of transient dependencies, and it's bringing in a pile
of new transient dependencies like opentelemetry. Avoid this problem going
forward by vendoring the remaining code we hadn't already.

Ref: #20146
tgross added a commit that referenced this pull request May 13, 2024
…20556)

We bring in `containernetworking/plugins` for the contents of a single file,
which we use in a few places for running a goroutine in a specific network
namespace. This code hasn't needed an update in a couple of years, and a good
chunk of what we need was previously vendored into `client/lib/nsutil`
already.

Updating the library via dependabot is causing errors in Docker driver tests
because it updates a lot of transient dependencies, and it's bringing in a pile
of new transient dependencies like opentelemetry. Avoid this problem going
forward by vendoring the remaining code we hadn't already.

Ref: #20146
tgross added a commit that referenced this pull request May 13, 2024
…t NS utils into release/1.6.x (#20569)

We bring in `containernetworking/plugins` for the contents of a single file,
which we use in a few places for running a goroutine in a specific network
namespace. This code hasn't needed an update in a couple of years, and a good
chunk of what we need was previously vendored into `client/lib/nsutil`
already.

Updating the library via dependabot is causing errors in Docker driver tests
because it updates a lot of transient dependencies, and it's bringing in a pile
of new transient dependencies like opentelemetry. Avoid this problem going
forward by vendoring the remaining code we hadn't already.

Ref: #20146

Co-authored-by: Tim Gross <tgross@hashicorp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stage/needs-investigation theme/dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant