New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump github.com/containernetworking/plugins from 1.2.0 to 1.4.1 #20146
chore(deps): bump github.com/containernetworking/plugins from 1.2.0 to 1.4.1 #20146
Conversation
26d80fe
to
8c283c5
Compare
8c283c5
to
573aeff
Compare
@dependabot rebase |
Bumps [github.com/containernetworking/plugins](https://github.com/containernetworking/plugins) from 1.2.0 to 1.4.1. - [Release notes](https://github.com/containernetworking/plugins/releases) - [Commits](containernetworking/plugins@v1.2.0...v1.4.1) --- updated-dependencies: - dependency-name: github.com/containernetworking/plugins dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
573aeff
to
0ed54ee
Compare
It doesn't look like there are any libcni changes here, so I'm going to backport this even though we don't especially need it just so that backport branches are up-to-date. |
Well apparently after rebasing this is causing some driver tests to fail. I can reproduce the test failure locally but not on |
So this is causing a bunch of errors in docker driver tests because it updates a ton of transient dependencies, and it's bringing in a pile of new transient dependencies like opentelemetry (!?). But it turns out that literally the only thing we bring it in for is a single file I'm going to refactor |
We bring in `containernetworking/plugins` for the contents of a single file, which we use in a few places for running a goroutine in a specific network namespace. This code hasn't needed an update in a couple of years, and a good chunk of what we need was previously vendored into `client/lib/nsutil` already. Updating the library via dependabot is causing errors in Docker driver tests because it updates a lot of transient dependencies, and it's bringing in a pile of new transient dependencies like opentelemetry. Avoid this problem going forward by vendoring the remaining code we hadn't already. Ref: #20146
Closing in lieu of #20556 |
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
…20556) We bring in `containernetworking/plugins` for the contents of a single file, which we use in a few places for running a goroutine in a specific network namespace. This code hasn't needed an update in a couple of years, and a good chunk of what we need was previously vendored into `client/lib/nsutil` already. Updating the library via dependabot is causing errors in Docker driver tests because it updates a lot of transient dependencies, and it's bringing in a pile of new transient dependencies like opentelemetry. Avoid this problem going forward by vendoring the remaining code we hadn't already. Ref: #20146
…20556) We bring in `containernetworking/plugins` for the contents of a single file, which we use in a few places for running a goroutine in a specific network namespace. This code hasn't needed an update in a couple of years, and a good chunk of what we need was previously vendored into `client/lib/nsutil` already. Updating the library via dependabot is causing errors in Docker driver tests because it updates a lot of transient dependencies, and it's bringing in a pile of new transient dependencies like opentelemetry. Avoid this problem going forward by vendoring the remaining code we hadn't already. Ref: #20146
…t NS utils into release/1.6.x (#20569) We bring in `containernetworking/plugins` for the contents of a single file, which we use in a few places for running a goroutine in a specific network namespace. This code hasn't needed an update in a couple of years, and a good chunk of what we need was previously vendored into `client/lib/nsutil` already. Updating the library via dependabot is causing errors in Docker driver tests because it updates a lot of transient dependencies, and it's bringing in a pile of new transient dependencies like opentelemetry. Avoid this problem going forward by vendoring the remaining code we hadn't already. Ref: #20146 Co-authored-by: Tim Gross <tgross@hashicorp.com>
Bumps github.com/containernetworking/plugins from 1.2.0 to 1.4.1.
Release notes
Sourced from github.com/containernetworking/plugins's releases.
Commits
8fc26ce
Merge pull request #991 from containernetworking/dependabot/docker/dot-github...c8d165d
Merge branch 'main' into dependabot/docker/dot-github/actions/retest-action/a...1b58119
Merge pull request #1010 from containernetworking/dependabot/github_actions/a...8a3014f
build(deps): bump actions/checkout from 3 to 4019727a
Merge pull request #1005 from austinvazquez/update-golangci-lint-action-package352e051
Update golangci-lint-action package to v49c016b5
Rename unused variables to resolve lint warnings0729398
Merge pull request #1017 from containernetworking/dependabot/go_modules/golan...394ab0d
build(deps): bump the golang group with 5 updates0144de0
Merge pull request #1011 from containernetworking/dependabot/github_actions/a...You can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)