CSI: include volume namespace in staging path #20532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross
force-pushed
the
csi-staging-conflicts
branch
from
ea3f559
to
7fd17db
Compare
tgross
force-pushed
the
csi-staging-conflicts
branch
2 times, most recently
from
294428e
to
0f746c2
Compare
tgross
requested review from
gulducat,
angrycub and
Juanadelacuesta
and removed request for
angrycub,
Juanadelacuesta and
gulducat
CSI volumes are are namespaced. But the client does not include the namespace in the staging mount path. This causes CSI volumes with the same volume ID but different namespace to collide if they happen to be placed on the same host. Fixes: #18741
Rework the CSI hook tests to have more fine-grained control over the mock on-disk state. Add tests covering upgrades from staging paths missing namespaces.
tgross
force-pushed
the
csi-staging-conflicts
branch
from
0f746c2
to
08f68cd
Compare
tgross
added
backport/1.6.x
| @@ -33,6 +33,12 @@ func (c *CallCounter) Get() map[string]int { | |||
| return maps.Clone(c.counts) | |||
| } | |||
|
|
|||
| func (c *CallCounter) Reset() { | |||
There was a problem hiding this comment.
Im failing to see where do we use this one
There was a problem hiding this comment.
Here so that we can use the MountVolume code path to setup an expected environment and then reset the calls so that the test assertion only lists the unmount/unpublish calls we expect.
Juanadelacuesta
approved these changes
May 13, 2024
This was referenced May 13, 2024
tgross
added a commit
that referenced
this pull request
May 13, 2024
CSI volumes are namespaced. But the client does not include the namespace in the staging mount path. This causes CSI volumes with the same volume ID but different namespace to collide if they happen to be placed on the same host. The per-allocation paths don't need to be namespaced, because an allocation can only mount volumes from its job's own namespace. Rework the CSI hook tests to have more fine-grained control over the mock on-disk state. Add tests covering upgrades from staging paths missing namespaces. Fixes: #18741
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSI volumes are namespaced. But the client does not include the namespace in the staging mount path. This causes CSI volumes with the same volume ID but different namespace to collide if they happen to be placed on the same host. The per-allocation paths don't need to be namespaced, because an allocation can only mount volumes from its job's own namespace.
Fixes: #18741
See #18741 (comment) for my notes on upgrade testing.