Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(provider-generator): sanitize all comments #2990

Merged
merged 7 commits into from
Jul 6, 2023
Merged

fix(provider-generator): sanitize all comments #2990

merged 7 commits into from
Jul 6, 2023

Conversation

DanielMSchmidt
Copy link
Contributor

@DanielMSchmidt DanielMSchmidt commented Jul 6, 2023 •
edited

This should fix the issues we see in Java for the google beta provider

@DanielMSchmidt DanielMSchmidt requested a review from a team as a code owner July 6, 2023 08:49
@DanielMSchmidt DanielMSchmidt requested review from mutahhir and ansgarm and removed request for a team July 6, 2023 08:49
@hashicorp-copywrite
chore: add required copyright headers
eba63b3 
Signed-off-by: hashicorp-copywrite[bot] <110428419+hashicorp-copywrite[bot]@users.noreply.github.com>
@DanielMSchmidt DanielMSchmidt changed the title fix comment ending sequence in provider docs fix(provider-generator): sanitize all comments Jul 6, 2023
mutahhir
mutahhir approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@mutahhir mutahhir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice abstraction. I think we could've gone a little farther and also just prefixed the * parts to the line function, but that's just a cosmetic preference.

packages/@cdktf/provider-generator/lib/get/generator/sanitized-comments.ts Show resolved Hide resolved
@DanielMSchmidt DanielMSchmidt added this pull request to the merge queue Jul 6, 2023
Merged via the queue into main with commit ea30bfd Jul 6, 2023
276 checks passed
@DanielMSchmidt DanielMSchmidt deleted the fix-comment-ending-sequence-in-provider-docs branch July 6, 2023 15:57
@jsteinich jsteinich mentioned this pull request Jul 23, 2023
Merged
8 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2023

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mutahhir mutahhir mutahhir approved these changes

@ansgarm ansgarm Awaiting requested review from ansgarm ansgarm is a code owner automatically assigned from hashicorp/cdktf

Assignees
No one assigned
Labels
ci/provider-integration ci/run-integration ci/run-unit/@cdktf/provider-generator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DanielMSchmidt @mutahhir @team-tf-cdk