Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Convert should use a typescript project to convert within #2992

Merged
merged 18 commits into from
Jul 14, 2023

Conversation

mutahhir
Copy link
Contributor

@mutahhir mutahhir commented Jul 6, 2023

Related issue

Fixes #2708

Description

This PR changes convert to be run within a tempoary folder with Typescript providers checked out before converting. This allows JSII rosetta to pick up the types it requires for converting to different languages.

This PR also adds an additional flag to convert where --without-project will skip creating the temporary folder.

Checklist

  • I have updated the PR title to match CDKTF's style guide
  • I have run the linter on my code locally
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if applicable
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works if applicable
  • New and existing unit tests pass locally with my changes

Signed-off-by: hashicorp-copywrite[bot] <110428419+hashicorp-copywrite[bot]@users.noreply.github.com>
packages/@cdktf/cli-core/templates/typescript/main.ts Outdated Show resolved Hide resolved
packages/cdktf-cli/src/bin/cmds/convert.ts Show resolved Hide resolved
packages/cdktf-cli/src/bin/cmds/handlers.ts Outdated Show resolved Hide resolved
packages/cdktf-cli/src/bin/cmds/handlers.ts Show resolved Hide resolved
@mutahhir mutahhir added this pull request to the merge queue Jul 14, 2023
Merged via the queue into main with commit 23ebd5b Jul 14, 2023
21 checks passed
@mutahhir mutahhir deleted the experiment-convert-with-ts-folder branch July 14, 2023 09:33
@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert: Use local bindings when running JSII-Rosetta
3 participants