Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use codemaker output in java #3000

Merged
merged 4 commits into from
Oct 16, 2023
Merged

fix: use codemaker output in java #3000

merged 4 commits into from
Oct 16, 2023

Conversation

DanielMSchmidt
Copy link
Contributor

@DanielMSchmidt DanielMSchmidt commented Jul 11, 2023 •
edited

This allows java users to set the right package name by allowing them to change the org

@DanielMSchmidt DanielMSchmidt requested a review from a team as a code owner July 11, 2023 15:07
@DanielMSchmidt DanielMSchmidt requested review from mutahhir and ansgarm and removed request for a team July 11, 2023 15:07
@DanielMSchmidt DanielMSchmidt marked this pull request as draft July 11, 2023 16:07
@DanielMSchmidt DanielMSchmidt added this to the 0.19 milestone Sep 1, 2023
@ansgarm ansgarm added the stretch-goal A stretch goal for the current release label Sep 5, 2023
@DanielMSchmidt DanielMSchmidt self-assigned this Oct 13, 2023
@DanielMSchmidt DanielMSchmidt marked this pull request as ready for review October 13, 2023 15:29
@ansgarm ansgarm added this pull request to the merge queue Oct 16, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Oct 16, 2023
@ansgarm ansgarm added this pull request to the merge queue Oct 16, 2023
Merged via the queue into main with commit 4941616 Oct 16, 2023
18 of 20 checks passed
@ansgarm ansgarm deleted the java-artifacts branch October 16, 2023 10:03
@ansgarm ansgarm mentioned this pull request Oct 16, 2023
Merged
@github-actions GitHub Actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ansgarm ansgarm ansgarm approved these changes

@mutahhir mutahhir Awaiting requested review from mutahhir mutahhir is a code owner automatically assigned from hashicorp/cdktf

Assignees

@DanielMSchmidt DanielMSchmidt

Labels
ci/provider-integration ci/run-examples ci/run-unit/@cdktf/cli-core ci/run-unit/@cdktf/provider-generator stretch-goal A stretch goal for the current release
Projects
None yet
Milestone
0.19
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DanielMSchmidt @ansgarm @team-tf-cdk