-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: move schema reading logic into package #3124
Conversation
2a02748
to
83919e7
Compare
Co-authored-by: Ansgar Mertens <ansgar@hashicorp.com>
Co-authored-by: Ansgar Mertens <ansgar@hashicorp.com>
Co-authored-by: Ansgar Mertens <ansgar@hashicorp.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one consistency nit left in the readme 😉 But good to go from my point of view!
Co-authored-by: Ansgar Mertens <ansgar@hashicorp.com>
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
The goal of this PR is to
In order to bring the last bit of goodness to the PR I decided to split our cache into multiple smaller ones so they are less often invalidated and more focussed on one topic.