Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix partial dependency update for Sentry #3172

Merged
merged 1 commit into from
Oct 5, 2023
Merged

fix: Fix partial dependency update for Sentry #3172

merged 1 commit into from
Oct 5, 2023

Conversation

ansgarm
Copy link
Member

@ansgarm ansgarm commented Oct 5, 2023 •
edited

Resolves #3171

@ansgarm ansgarm requested a review from a team as a code owner October 5, 2023 09:05
@ansgarm ansgarm requested review from mutahhir and DanielMSchmidt and removed request for a team October 5, 2023 09:05
mutahhir
mutahhir approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@mutahhir mutahhir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you write a couple of lines why unknown fixes the problem for context. Otherwise LGTM

@ansgarm
Copy link
Member Author

ansgarm commented Oct 5, 2023

Can you write a couple of lines why unknown fixes the problem for context. Otherwise LGTM

The problem was that we had different versions of Sentry in place (I suspect Sentry installs itself globally if not already present, causing a mismatch in expected methods on the global Sentry). The change for unknown is just a requirement from updating Sentry for the cli-core package.

@ansgarm ansgarm added this pull request to the merge queue Oct 5, 2023
Merged via the queue into main with commit b19a0d8 Oct 5, 2023
52 of 56 checks passed
@ansgarm ansgarm deleted the fix-sentry-dependency-update branch October 5, 2023 09:19
@ansgarm ansgarm mentioned this pull request Oct 5, 2023
Merged
ansgarm added a commit that referenced this pull request Oct 5, 2023
@ansgarm
chore(release): Update CHANGELOG.md and version to 0.18.2 (#3173)
60c27c2 
## 0.18.2

Fixes a bug in 0.18.1 that broke crash reporting due to a partial
dependency upgrade.

### fix

- fix: Fix partial dependency update for Sentry
[\#3172](#3172)
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2023

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mutahhir mutahhir mutahhir approved these changes

@xiehan xiehan xiehan approved these changes

@DanielMSchmidt DanielMSchmidt Awaiting requested review from DanielMSchmidt DanielMSchmidt is a code owner automatically assigned from hashicorp/cdktf

Assignees
No one assigned
Labels
ci/run-unit/@cdktf/cli-core ci/run-unit/cdktf-cli
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError: t.update is not a function
4 participants
@ansgarm @mutahhir @xiehan @team-tf-cdk