Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial support for provider-defined functions from providers schema -json #119

Merged
merged 2 commits into from Jan 19, 2024

Conversation

bflad
Copy link
Member

@bflad bflad commented Jan 11, 2024

Closes #118
Reference: hashicorp/terraform#34450

The Terraform providers schema -json output implementation currently uses the entire metadata functions -json implementation, so has the additional nesting layer containing format_version and function_signatures.

…-json

Reference: #118
Reference: hashicorp/terraform#34450

The Terraform `providers schema -json` output implementation currently uses the entire `metadata functions -json` implementation, so has the additional nesting layer containing `format_version` and `function_signatures`.
@bflad bflad requested review from a team as code owners January 11, 2024 22:47
@bflad bflad added the enhancement New feature or request label Jan 11, 2024
Copy link
Contributor

@bendbennett bendbennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@bflad
Copy link
Member Author

bflad commented Jan 16, 2024

There are still some discussions on whether the "extra" object containing the format_version/function_signatures properties should be in the providers schema -json output. It wasn't in the RFC and could be confusing. Once all that is sorted will make any changes and merge after a 👍 from core.

Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@radeksimko radeksimko merged commit f2686e9 into main Jan 19, 2024
8 checks passed
@radeksimko radeksimko deleted the bflad/provider-functions branch January 19, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Provider-Defined Functions
4 participants