Check for practioner-set timeout during ReadDataApply

[bcmdarroch]

Fixes:

• Timeouts are not applied to a Data Source read during apply #1038
• hcp_azure_peering_connection Data Source times out too soon terraform-provider-hcp#377

To test, pull this commit into your provider's go.mod. Set any datasource timeout to 1 min. Apply.

var readTimeout = time.Minute * 1
...
Timeouts: &schema.ResourceTimeout{
	Read: &readTimeout,
},

[bflad]

Hi again @bcmdarroch! 👋

It looks like over in #1038 the workaround of using ReadWithoutTimeout was determined. In general, not using practitioner-configurable data source timeouts would be our recommendation for this situation since it could lead to practitioner confusion or configuration ambiguity.

While this particular code change may start the resolution process should practitioner-configurable timeouts have a proper use case, there would also need to be some additional testing to ensure that this wouldn't potentially introduce unexpected panics or other unintended data source behaviors. Since those tests aren't currently included, I'm going to close this for now. If you or someone else is interested in implementing them, we'd be happy to take another look.

Thanks again!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.