Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed non-sdk best practice documentation #1170

Merged
merged 12 commits into from
Mar 17, 2023
Merged

Conversation

austinvalle
Copy link
Member

@austinvalle austinvalle commented Mar 13, 2023

closes #1151

Related PRs:

Notes

@austinvalle austinvalle changed the title (WIP) Removed non-sdk best practice documentation Removed non-sdk best practice documentation Mar 13, 2023
@austinvalle austinvalle marked this pull request as ready for review March 13, 2023 20:39
@austinvalle austinvalle requested a review from a team as a code owner March 13, 2023 20:39
Copy link
Contributor

@bendbennett bendbennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

As you suggested, a callout on Overview page of SDKv2 that some sections have been moved to the Plugin Development section sounds like a good idea.

@austinvalle
Copy link
Member Author

As you suggested, a callout on Overview page of SDKv2 that some sections have been moved to the Plugin Development section sounds like a good idea.

Added in aa8be73

Copy link
Member

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀

website/docs/plugin/sdkv2/best-practices/index.mdx Outdated Show resolved Hide resolved
@bflad bflad added the documentation Improvements or additions to documentation label Mar 15, 2023
@bflad bflad added this to the v2.26.0 milestone Mar 15, 2023
Co-authored-by: Brian Flad <bflad417@gmail.com>
@austinvalle austinvalle merged commit dc034f3 into main Mar 17, 2023
@austinvalle austinvalle deleted the av/migrate-best-practices branch March 17, 2023 18:58
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate Non-SDK Specific Best Practices Documentation
3 participants