Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: Fix version number, deprecate exported variables and function #1260

Merged
merged 3 commits into from
Oct 11, 2023

Conversation

bflad
Copy link
Member

@bflad bflad commented Oct 11, 2023

Closes #1257

The release process is also updated to automatically overwrite the version variable as it did in the previous release process. While this should ensure this version information is correct going forward, consumers should instead prefer the Go standard library runtime/debug package build information, which is guaranteed to always be correct.

Reference: #1257

The release process is also updated to automatically overwrite the version variable as it did in the previous release process. While this should ensure this version information is correct going forward, consumers should instead prefer the Go standard library `runtime/debug` package build information, which is guaranteed to always be correct.
@bflad bflad added the bug Something isn't working label Oct 11, 2023
@bflad bflad added this to the v2.30.0 milestone Oct 11, 2023
@bflad bflad requested a review from a team as a code owner October 11, 2023 13:50
Copy link
Member

@austinvalle austinvalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

meta/meta.go Outdated Show resolved Hide resolved
@bflad bflad merged commit 4081ee8 into main Oct 11, 2023
7 checks passed
@bflad bflad deleted the bflad/meta-version branch October 11, 2023 15:46
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

meta.SDKVersion reporting incorrect version
2 participants