Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: Add automatic deferred action support for unknown provider configuration #1335

Merged
merged 31 commits into from
May 17, 2024
Merged

all: Add automatic deferred action support for unknown provider configuration #1335

merged 31 commits into from
May 17, 2024

Conversation

austinvalle
Copy link
Member

Ref: hashicorp/terraform-plugin-go#403

This PR implements deferred action support for PROVIDER_CONFIG_UNKNOWN during the ConfigureProvider RPC. This functionality will allow a provider to defer all resources and data sources associated with the SDKv2 provider during the ReadResource, ReadDataSource, ImportResourceState, and PlanResourceChange RPCs.

Deferred actions is an experimental feature introduced in Terraform v1.9.0-alpha20240404 and is only available in experimental Terraform builds.

More granular deferred action support will be available in terraform-plugin-framework.

@austinvalle austinvalle added the enhancement New feature or request label May 6, 2024
@austinvalle austinvalle added this to the v2.34.0 milestone May 6, 2024
@austinvalle austinvalle requested a review from a team as a code owner May 6, 2024 19:14
austinvalle
austinvalle commented May 6, 2024
View reviewed changes
go.mod Outdated Show resolved Hide resolved
bflad
bflad approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me 🚀 Just some minor considerations along the way.

.changes/unreleased/FEATURES-20240506-152018.yaml Outdated Show resolved Hide resolved
helper/schema/deferred_response.go Outdated Show resolved Hide resolved
helper/schema/grpc_provider.go Outdated Show resolved Hide resolved
helper/schema/grpc_provider.go Outdated Show resolved Hide resolved
helper/schema/grpc_provider.go Show resolved Hide resolved
helper/schema/grpc_provider.go Outdated Show resolved Hide resolved
helper/schema/grpc_provider_test.go Outdated Show resolved Hide resolved
@austinvalle austinvalle mentioned this pull request May 9, 2024
Merged
bflad
bflad approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Followup changes all look good to me still 😄

@austinvalle austinvalle merged commit 02c429c into main May 17, 2024
7 checks passed
@austinvalle austinvalle deleted the av/dfa branch May 17, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v2.34.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@austinvalle @bflad