Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type Block need handle attribute marked as removed contionally. #359

Open
wants to merge 2 commits into
base: v1-maint
Choose a base branch
from

Commits on Jul 30, 2020

  1. Type Block need handle attribute marked as removed contionally.

    In some provider, e.g. AzureRM, TypeSet is use quite prevalent to
    hold a set of sub-resources (e.g. security_rule in azurerm_network_security_group).
    The reason for using TypeSet instead of TypeList might because service
    return a collection of info with arbitrary order, or other reasons.
    
    In this case: Given a slice of nested blocks, if one of the nested block (B1)
    attributes is optional and has no default value, and user didn't specify a value
    for it. Then if another nested block (B2) changed, which triggers some diff,
    then B1 will also be replaced. That is because the optional attribute
    contribute a diff of "zero value" -> `null`, which changed the hash of
    the block.
    
    This fix is to carefully handle this case. We keep attribute marked
    as `NewRemoved` after a `diffString` only when all the attributes are
    marked as such. Otherwise, as long as one attribute is not marked to be
    removed, that means this block will be kept. Then we will manipulate the
    attributes in this block, which being marked as removed just because
    user didn't specify a value and the original value is the zero value.
    
    This keeps consistent as other Resource types (e.g. List Resource).
    (Though those type just remove the attribute from diff set, while for
    Set we need to return the complete state as we will not depend on the
    old state during diff apply).
    magodo committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    b6e3d58 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2020

  1. Update the zero value comparison logic.

    The state representation will only store the primary values, hence
    we only need to take care of those.
    magodo committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    d38953e View commit details
    Browse the repository at this point in the history