Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helper/schema: Schema.DiffSuppressOnRefresh #882

Merged
merged 1 commit into from Feb 17, 2022
Merged

Commits on Feb 16, 2022

  1. helper/schema: Schema.DiffSuppressOnRefresh

    Unfortunately in the original design of DiffSuppressFunc we made it work
    only during planning, and so the normalization vs. drift classification
    it does isn't honored in any other situation.
    
    Unilaterally enabling it for both refresh and apply would be too risky at
    this late stage where so many existing provider behaviors rely on these
    subtle details, but here we introduce a more surgical _opt-in_ mechanism
    whereby specific attributes can be set to also check the Refresh result
    against DiffSuppressFunc, and so avoid reporting any normalization done
    by the remote system as if it were drift.
    
    This behavior will be primarily useful for strings containing complex data
    serialized into some particular microsyntax which allows expressing the
    same information multiple ways. In particular, existing situations where
    we classify whitespace changes and other such immaterial changes in JSON
    values as normalization vs. drift would be a good candidate to enable
    this flag, so that we can get the same results during refreshing and thus
    avoid churning any downstream resources that refer to the
    unexpectedly-updated result.
    apparentlymart committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    84f804f View commit details
    Browse the repository at this point in the history