r/aws_ec2_instance: Support modifying an ec2 instance's IPv6 addresses in-place

[hfinucane]

Description

This allows you to set specific IPv6 addresses on an EC2 instance, without triggering an instance replacement.

This also switches to using a set for aws_instance.ipv6_addresses, on the grounds that AWS treats it as a set. I'm a little nervous about this, although it seems to go fine in practice.

Output from Acceptance Testing

#> make testacc TESTARGS='-run=TestAccEC2Instance_IPv6\|TestAccEC2Instance_basic\|TestAccEC2Instance_ipv6AddressCountAndSingleAddressCausesError\|TestAccEC2Instance_IPv6_supportIPv6Addresses' PKG=ec2 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ec2/... -v -count 1 -parallel 3  -run=TestAccEC2Instance_IPv6\|TestAccEC2Instance_basic\|TestAccEC2Instance_ipv6AddressCountAndSingleAddressCausesError\|TestAccEC2Instance_IPv6_supportIPv6Addresses -timeout 360m
=== RUN   TestAccEC2Instance_basic
=== PAUSE TestAccEC2Instance_basic
=== RUN   TestAccEC2Instance_IPv6_supportAddressCount
=== PAUSE TestAccEC2Instance_IPv6_supportAddressCount
=== RUN   TestAccEC2Instance_ipv6AddressCountAndSingleAddressCausesError
=== PAUSE TestAccEC2Instance_ipv6AddressCountAndSingleAddressCausesError
=== RUN   TestAccEC2Instance_IPv6_supportAddressCountWithIPv4
=== PAUSE TestAccEC2Instance_IPv6_supportAddressCountWithIPv4
=== RUN   TestAccEC2Instance_IPv6_supportIPv6Addresses
=== PAUSE TestAccEC2Instance_IPv6_supportIPv6Addresses
=== RUN   TestAccEC2Instance_IPv6AddressCount
=== PAUSE TestAccEC2Instance_IPv6AddressCount
=== RUN   TestAccEC2Instance_basicWithSpot
=== PAUSE TestAccEC2Instance_basicWithSpot
=== CONT  TestAccEC2Instance_basic
=== CONT  TestAccEC2Instance_IPv6_supportIPv6Addresses
=== CONT  TestAccEC2Instance_basicWithSpot
--- PASS: TestAccEC2Instance_basic (183.68s)
=== CONT  TestAccEC2Instance_IPv6AddressCount
--- PASS: TestAccEC2Instance_IPv6_supportIPv6Addresses (313.23s)
=== CONT  TestAccEC2Instance_ipv6AddressCountAndSingleAddressCausesError
--- PASS: TestAccEC2Instance_ipv6AddressCountAndSingleAddressCausesError (4.42s)
=== CONT  TestAccEC2Instance_IPv6_supportAddressCountWithIPv4
--- PASS: TestAccEC2Instance_IPv6AddressCount (228.67s)
=== CONT  TestAccEC2Instance_IPv6_supportAddressCount
--- PASS: TestAccEC2Instance_basicWithSpot (426.71s)
--- PASS: TestAccEC2Instance_IPv6_supportAddressCountWithIPv4 (178.24s)
--- PASS: TestAccEC2Instance_IPv6_supportAddressCount (165.86s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	584.663s
...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[hfinucane]

Can I rerun the checks? The failing ones all look like github actions getting ratelimited by dockerhub

(yes, rebased & re-pushed)