Removed forceNew flag from resource_service_principal tags (#245)

hashicorp/terraform-provider-azurerm#6580
hashicorp · May 14, 2020 · d52535a · d52535a
1 parent 9ac410f
commit d52535a
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/azuread/resource_service_principal.go b/azuread/resource_service_principal.go
@@ -55,7 +55,6 @@ func resourceServicePrincipal() *schema.Resource {
 			"tags": {
 				Type:     schema.TypeSet,
 				Optional: true,
-				ForceNew: true,
 				Set:      schema.HashString,
 				Elem: &schema.Schema{
 					Type: schema.TypeString,
@@ -115,6 +114,15 @@ func resourceServicePrincipalUpdate(d *schema.ResourceData, meta interface{}) er
 		properties.AppRoleAssignmentRequired = p.Bool(d.Get("app_role_assignment_required").(bool))
 	}
 
+	if d.HasChange("tags") {
+		if v, ok := d.GetOk("tags"); ok {
+			properties.Tags = tf.ExpandStringSlicePtr(v.(*schema.Set).List())
+		} else {
+			empty := []string{} // clear tags with empty array
+			properties.Tags = &empty
+		}
+	}
+
 	if _, err := client.Update(ctx, d.Id(), properties); err != nil {
 		return fmt.Errorf("Error patching Azure AD Service Principal with ID %q: %+v", d.Id(), err)
 	}