Skip to content

Commit

Permalink
[BUG] azurerm_redis_cache backup requires connection string
Browse files Browse the repository at this point in the history
Co-authored-by: kt <kt@katbyte.me>
  • Loading branch information
Clara McKenzie committed May 7, 2020
1 parent ad5bedf commit 698ed80
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 0 deletions.
6 changes: 6 additions & 0 deletions azurerm/internal/services/redis/resource_arm_redis_cache.go
Expand Up @@ -672,6 +672,12 @@ func expandRedisConfiguration(d *schema.ResourceData) (map[string]*string, error

// RDB Backup
if v, ok := d.GetOk("redis_configuration.0.rdb_backup_enabled"); ok {
backupEnabled := v.(bool)
if backupEnabled == true {
if v, ok := d.GetOk("redis_configuration.0.rdb_storage_connection_string"); !ok || v.(string) != "" {
return nil, fmt.Errorf("The rdb_storage_connection_string property must be set when rdb_backup_enabled is true")
}
}
delta := strconv.FormatBool(v.(bool))
output["rdb-backup-enabled"] = utils.String(delta)
}
Expand Down
3 changes: 3 additions & 0 deletions website/docs/r/redis_cache.html.markdown
Expand Up @@ -92,6 +92,9 @@ A `redis_configuration` block supports the following:
* `maxfragmentationmemory_reserved` - (Optional) Value in megabytes reserved to accommodate for memory fragmentation. Defaults are shown below.

* `rdb_backup_enabled` - (Optional) Is Backup Enabled? Only supported on Premium SKU's.

-> **NOTE:** If set to `true`, `rdb_storage_connection_string` must also be set.

* `rdb_backup_frequency` - (Optional) The Backup Frequency in Minutes. Only supported on Premium SKU's. Possible values are: `15`, `30`, `60`, `360`, `720` and `1440`.
* `rdb_backup_max_snapshot_count` - (Optional) The maximum number of snapshots to create as a backup. Only supported for Premium SKU's.
* `rdb_storage_connection_string` - (Optional) The Connection String to the Storage Account. Only supported for Premium SKU's. In the format: `DefaultEndpointsProtocol=https;BlobEndpoint=${azurerm_storage_account.example.primary_blob_endpoint};AccountName=${azurerm_storage_account.example.name};AccountKey=${azurerm_storage_account.example.primary_access_key}`.
Expand Down

0 comments on commit 698ed80

Please sign in to comment.