Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_function_app & azurerm_function_app_slot support for ip-restrictions scm/kudu site #7431

Closed
SebRosander opened this issue Jun 22, 2020 · 3 comments
Milestone

Comments

@SebRosander
Copy link
Contributor

SebRosander commented Jun 22, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Add support for ip-restrictions scm/kudu site for function app & slot.

New or Affected Resource(s)

  • azurerm_function_app
  • azurerm_function_app_slot

Potential Terraform Configuration

  site_config {
   # Current network IP address restriction on function app
    ip_restriction {
      ip_address  = "1.2.3.4"
    }

   # Proposed new IP address restriction on function app SCM/KUDU site
    scm_ip_restriction {
      ip_address  = "5.6.7.8"
    }
  }
}

References

@SebRosander SebRosander changed the title azurerm_function_app support for ip-restrictions scm/kudu site azurerm_function_app & azurerm_function_app_slot support for ip-restrictions scm/kudu site Jun 23, 2020
@alastairtree
Copy link
Contributor

Thank you for this. The attached PR actually puts functions ahead of app service in terms of functionality because we still don't have IP Restrictions for SCM on app service slots yet.

@jackofallops jackofallops added this to the v2.23.0 milestone Aug 14, 2020
@jackofallops
Copy link
Member

closed by #7945 - released in 2.23.0

@ghost
Copy link

ghost commented Sep 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Sep 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants